summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authormarja <marja@chromium.org>2015-03-09 10:13:40 -0700
committerCommit bot <commit-bot@chromium.org>2015-03-09 17:14:28 +0000
commita017dc48049f5401d15f00cb20a741f803d719ad (patch)
tree2c6206018f87074baba9198e4bbfd4f32b624f40 /PRESUBMIT.py
parentf00002a0cfc699faa4228b697ac77ee433df06d0 (diff)
downloadchromium_src-a017dc48049f5401d15f00cb20a741f803d719ad.zip
chromium_src-a017dc48049f5401d15f00cb20a741f803d719ad.tar.gz
chromium_src-a017dc48049f5401d15f00cb20a741f803d719ad.tar.bz2
PRESUBMIT.py, more helpful and stable error message for #include check.
Most problems are because of wrong collation or not reading the style guide, so pointing people to those. BUG= Review URL: https://codereview.chromium.org/989533002 Cr-Commit-Position: refs/heads/master@{#319660}
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 8bfd5cf..d631d4f 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -62,9 +62,9 @@ _TEST_ONLY_WARNING = (
_INCLUDE_ORDER_WARNING = (
- 'Your #include order seems to be broken. Send mail to\n'
- 'marja@chromium.org if this is not the case.')
-
+ 'Your #include order seems to be broken. Remember to use the right '
+ 'collation (LC_COLLATE=C) and check https://google-styleguide.googlecode'
+ '.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes')
_BANNED_OBJC_FUNCTIONS = (
(