diff options
| author | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-29 18:44:39 +0000 |
|---|---|---|
| committer | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-29 18:44:39 +0000 |
| commit | b3fbe1c3b1457bd04a4e71855ed53b98f5d6f113 (patch) | |
| tree | c9f625d15548e30f49c630e3397bb8dde15087f6 /PRESUBMIT.py | |
| parent | 335be9a4d68ba6e7e29dfc26bb1496bb15a0d663 (diff) | |
| download | chromium_src-b3fbe1c3b1457bd04a4e71855ed53b98f5d6f113.zip chromium_src-b3fbe1c3b1457bd04a4e71855ed53b98f5d6f113.tar.gz chromium_src-b3fbe1c3b1457bd04a4e71855ed53b98f5d6f113.tar.bz2 | |
Make the "tree is closed" presubmit check an error, not a
warning. pressing "y" is too easy. It's better to have to
use "--force" or "--no_presubmit"
Review URL: http://codereview.chromium.org/159596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21978 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT.py')
| -rwxr-xr-x | PRESUBMIT.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index cbe2d9f..8e0ac49 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -135,8 +135,8 @@ def CheckTreeIsOpen(input_api, output_api, url, closed, url_text): long_text = match.group(1).strip() except IOError: pass - return [output_api.PresubmitPromptWarning("The tree is closed.", - long_text=long_text)] + return [output_api.PresubmitError("The tree is closed.", + long_text=long_text)] except IOError: pass return [] |