summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT_test.py
diff options
context:
space:
mode:
authormostynb <mostynb@opera.com>2014-10-22 06:21:29 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-22 13:21:49 +0000
commit5a73a5d37237fcf25bb05571a314193188600c65 (patch)
tree44935f43ad9a127cc49db1901fb316f73b80b25b /PRESUBMIT_test.py
parentfd4440e67bd92bd7b94d6e57ee8b445aebcda15e (diff)
downloadchromium_src-5a73a5d37237fcf25bb05571a314193188600c65.zip
chromium_src-5a73a5d37237fcf25bb05571a314193188600c65.tar.gz
chromium_src-5a73a5d37237fcf25bb05571a314193188600c65.tar.bz2
remove obsolete OVERRIDE/FINAL presubmit checks
BUG=417463 Review URL: https://codereview.chromium.org/655693003 Cr-Commit-Position: refs/heads/master@{#300675}
Diffstat (limited to 'PRESUBMIT_test.py')
-rwxr-xr-xPRESUBMIT_test.py60
1 files changed, 0 insertions, 60 deletions
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py
index 02a10c6..edac74a 100755
--- a/PRESUBMIT_test.py
+++ b/PRESUBMIT_test.py
@@ -413,66 +413,6 @@ class InvalidOSMacroNamesTest(unittest.TestCase):
self.assertEqual(0, len(errors))
-class InvalidOverideAndFinalTest(unittest.TestCase):
- def testValidOverrideConstructs(self):
- mock_input_api = MockInputApi()
- lines = ['foo1() override;',
- 'foo2() final;',
- '#DEFINE OVERRIDE_METHOD_OVERLOAD',
- '#DEFINE FINAL_METHOD',
- '#DEFINE OVERRIDE_OVERRIDE_SOMETHING',
- '#DEFINE SOMETHING_OVERRIDE_SOMETHING',
- '#DEFINE SOMETHING_SOMETHING_OVERRIDE',
- '#DEFINE FINAL_OVERRIDE_FINAL',
- '#DEFINE SOMETHING_OVERRIDE_FINAL',
- '#DEFINE OVERRIDE_OVERRIDE_OVERRIDE',
- '#endif // FINAL_METHOD',
- '#endif // OVERRIDE_METHOD_OVERLOAD']
- mock_file_h = MockFile('something.h', lines)
- mock_input_api.files = [mock_file_h]
- errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
- MockOutputApi())
- self.assertEqual(0, len(errors))
-
- def testInvalidOverrideConstructsInHeaders(self):
- mock_input_api = MockInputApi()
- lines_cpp = ['foo2() FINAL;']
- lines_h = ['foo1() OVERRIDE;']
- mock_file_cpp = MockFile('something.cpp', lines_cpp)
- mock_file_h = MockFile('something.h', lines_h)
- mock_input_api.files = [mock_file_cpp, mock_file_h]
- errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
- MockOutputApi())
- self.assertEqual(1, len(errors))
-
- def testInvalidOverrideConstructsInCpp(self):
- mock_input_api = MockInputApi()
- lines_cpp = ['foo2() FINAL;']
- mock_file_cpp = MockFile('something.cpp', lines_cpp)
- mock_input_api.files = [mock_file_cpp]
- errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
- MockOutputApi())
- self.assertEqual(1, len(errors))
-
- def testInvalidOverrideConstructsInCc(self):
- mock_input_api = MockInputApi()
- lines_cc = ['foo3() override FINAL;']
- mock_file_cc = MockFile('something.cc', lines_cc)
- mock_input_api.files = [mock_file_cc]
- errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
- MockOutputApi())
- self.assertEqual(1, len(errors))
-
- def testInvalidOverrideConstructsInMm(self):
- mock_input_api = MockInputApi()
- lines_mm = ['foo4() OVERRIDE final;']
- mock_file_mm = MockFile('something.mm', lines_mm)
- mock_input_api.files = [mock_file_mm]
- errors = PRESUBMIT._CheckForOverrideAndFinalRules(mock_input_api,
- MockOutputApi())
- self.assertEqual(1, len(errors))
-
-
class InvalidIfDefinedMacroNamesTest(unittest.TestCase):
def testInvalidIfDefinedMacroNames(self):
lines = ['#if defined(TARGET_IPHONE_SIMULATOR)',