diff options
author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-08 01:15:41 +0000 |
---|---|---|
committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-08 01:15:41 +0000 |
commit | 14a6131ccc19f95f058d39e038b7bbed21431688 (patch) | |
tree | 3b6779a8c2fc62393a504b4e8a427dd51ef5483e /PRESUBMIT_test.py | |
parent | 566755f8730890267205b6f6e290f72356e79fee (diff) | |
download | chromium_src-14a6131ccc19f95f058d39e038b7bbed21431688.zip chromium_src-14a6131ccc19f95f058d39e038b7bbed21431688.tar.gz chromium_src-14a6131ccc19f95f058d39e038b7bbed21431688.tar.bz2 |
Do per-file OWNERS check for per-file DEPS changes.
Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file.
BUG=290401
Review URL: https://codereview.chromium.org/116443011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'PRESUBMIT_test.py')
-rwxr-xr-x | PRESUBMIT_test.py | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py index c6b280a..2d6e066 100755 --- a/PRESUBMIT_test.py +++ b/PRESUBMIT_test.py @@ -394,7 +394,7 @@ class InvalidOSMacroNamesTest(unittest.TestCase): class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase): - def testDepsFilesToCheck(self): + def testFilesToCheckForIncomingDeps(self): changed_lines = [ '"+breakpad",', '"+chrome/installer",', @@ -404,6 +404,7 @@ class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase): '"+components/breakpad",', '"+components/nacl/common",', '"+content/public/browser/render_process_host.h",', + '"+jni/fooblat.h",', '"+grit", # For generated headers', '"+grit/generated_resources.h",', '"+grit/",', @@ -412,20 +413,20 @@ class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase): '"+tools/memory_watcher",', '"+third_party/lss/linux_syscall_support.h",', ] - files_to_check = PRESUBMIT._DepsFilesToCheck(re, changed_lines) + files_to_check = PRESUBMIT._FilesToCheckForIncomingDeps(re, changed_lines) expected = set([ 'breakpad/DEPS', 'chrome/installer/DEPS', - 'chrome/plugin/DEPS', - 'chrome/utility/DEPS', - 'chromeos/DEPS', + 'chrome/plugin/chrome_content_plugin_client.h', + 'chrome/utility/chrome_content_utility_client.h', + 'chromeos/chromeos_paths.h', 'components/breakpad/DEPS', 'components/nacl/common/DEPS', - 'content/public/browser/DEPS', + 'content/public/browser/render_process_host.h', 'policy/DEPS', 'sandbox/DEPS', 'tools/memory_watcher/DEPS', - 'third_party/lss/DEPS', + 'third_party/lss/linux_syscall_support.h', ]) self.assertEqual(expected, files_to_check); |