diff options
author | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 17:41:31 +0000 |
---|---|---|
committer | mirandac@chromium.org <mirandac@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 17:41:31 +0000 |
commit | 7538527e096ed6720001ff54052caf866455acd4 (patch) | |
tree | a7aeed75ba7799663d60379bef0d751b723133a4 /WATCHLISTS | |
parent | 42263af3f9452bddc85762f43db13ad477b0df4c (diff) | |
download | chromium_src-7538527e096ed6720001ff54052caf866455acd4.zip chromium_src-7538527e096ed6720001ff54052caf866455acd4.tar.gz chromium_src-7538527e096ed6720001ff54052caf866455acd4.tar.bz2 |
The problem here seems to have been a race condition between the animator wanting to draw the status bubble and the browser window closing sequence. If the animation is always reset when the status bubble is detached (which is the correct thing to do, and this not being the case was actually causing another, more subtle bug), the animation sequence should never be running when the window is shutting down.
(No delegate is needed to watch for the expansion stop, because this case doesn't trigger a state change -- the state "is_expanded" is true when the bubble has been expanded, and ceases to be true when the bubble is hidden. The bubble will remain in "is_expanded" mode while the user moves quickly from one bubble to the next, expanding and contracting to fit the new links without pausing for a hover delay).
BUG=57600
TEST=open several browsers. hover over a long (elided) link on the top browser. wait for the expansion -- kill the window quickly, as it expands! repeat -- browser should not crash. browser should never crash if closing while expanding in any circumstance.
Review URL: http://codereview.chromium.org/3564021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61973 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'WATCHLISTS')
0 files changed, 0 insertions, 0 deletions