diff options
| author | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-04 22:55:43 +0000 |
|---|---|---|
| committer | mnaganov@chromium.org <mnaganov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-12-04 22:55:43 +0000 |
| commit | 2908f2cef8990d5c01dfc1d871df56cd1fae2ce4 (patch) | |
| tree | 7aa820c0732b1f3112b0c5c0c71d3e43219d632e /android_webview/browser | |
| parent | 383ca80a4d2389c328044d5c98162101b80dd297 (diff) | |
| download | chromium_src-2908f2cef8990d5c01dfc1d871df56cd1fae2ce4.zip chromium_src-2908f2cef8990d5c01dfc1d871df56cd1fae2ce4.tar.gz chromium_src-2908f2cef8990d5c01dfc1d871df56cd1fae2ce4.tar.bz2 | |
[Android] Implement WebSettings.setAppCache{Enabled|Path}
AppCacheEnabled is mapped onto WebPreferences.application_cache_enabled, which goes directly into WebKit Settings.
AppCachePath is only used as a flag to enable AppCache. We can't make use of the full path given, because in Chromium the Application Cache directory lives inside the browser context (profile).
The tests added trigger a DCHECK in disk cache, unless the profile is empty when the test starts. This makes impossible to run them both now, so only one of them is enabled for now.
Android CTS tests WebSettings.testAppCache{Disabled|Enabled} are passing with this patch.
Review URL: https://chromiumcodereview.appspot.com/11411229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171074 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview/browser')
| -rw-r--r-- | android_webview/browser/aw_content_browser_client.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc index e579e22..62f92ec 100644 --- a/android_webview/browser/aw_content_browser_client.cc +++ b/android_webview/browser/aw_content_browser_client.cc @@ -114,9 +114,9 @@ gfx::ImageSkia* AwContentBrowserClient::GetDefaultFavicon() { bool AwContentBrowserClient::AllowAppCache(const GURL& manifest_url, const GURL& first_party, content::ResourceContext* context) { - // TODO(boliu): Implement this to power WebSettings.SetAppCacheEnabled. - NOTIMPLEMENTED(); - return false; + // WebView doesn't have a per-site policy for locally stored data, + // instead AppCache can be disabled for individual WebViews. + return true; } |