diff options
| author | hjd@chromium.org <hjd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-20 18:22:13 +0000 |
|---|---|---|
| committer | hjd@chromium.org <hjd@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-20 18:22:13 +0000 |
| commit | 66453fddc130f5775efc1bf42e7e78c2da80281f (patch) | |
| tree | a00e276f9a3c4c1e690a5003fb1843843278f52c /android_webview/buildbot | |
| parent | c8d4b1ebcb97834daa9ebb42ce9d3f625b55b2a8 (diff) | |
| download | chromium_src-66453fddc130f5775efc1bf42e7e78c2da80281f.zip chromium_src-66453fddc130f5775efc1bf42e7e78c2da80281f.tar.gz chromium_src-66453fddc130f5775efc1bf42e7e78c2da80281f.tar.bz2 | |
Fixes a deadlock between shouldInterceptRequest() and getCookie()
In the WebView shouldInterceptRequest is called on the IO thread.
The CookieManager used to post cookie monster tasks to a thread
which was sometimes the IO thread (if the WebView was started
before the CookieManager) but sometimes a special thread (if the
CookieManager was started before the WebView).
getCookie is synchronous and blocks waiting for the result after
posting its task so if getCookie was called from
shouldInterceptRequest and the cookie monster was on the IO thread
then it deadlocked.
We fix this by always starting the special thread for the cookie
monster.
Android Issue: https://code.google.com/p/android/issues/detail?id=65786
BUG=374203
Review URL: https://codereview.chromium.org/284313005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271715 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview/buildbot')
0 files changed, 0 insertions, 0 deletions