diff options
| author | primiano <primiano@chromium.org> | 2015-05-26 02:44:33 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-26 09:44:56 +0000 |
| commit | c1a8f160007a31acc4a50fcba1d94d65fe60993e (patch) | |
| tree | 8166bacfa584ded335f6a746b1ed7cc39c14574e /android_webview/crash_reporter | |
| parent | c1801634a3f55a36b0b1895e4723749d25445410 (diff) | |
| download | chromium_src-c1a8f160007a31acc4a50fcba1d94d65fe60993e.zip chromium_src-c1a8f160007a31acc4a50fcba1d94d65fe60993e.tar.gz chromium_src-c1a8f160007a31acc4a50fcba1d94d65fe60993e.tar.bz2 | |
android-webview: Add WebView version to microdumps.
Add the plumbing to return the right product name and version
to breakpad, which will be propagated into the microdump.
The new microdump output looks as follows:
--------- beginning of main
W/google-breakpad(25214): -----BEGIN BREAKPAD MICRODUMP-----
W/google-breakpad(25214): V WebView:44.0.2403.0
W/google-breakpad(25214): O A arm 04 google/occam/mako:5.1.1/LMY48D/1906941:userdebug/dev-keys
[the rest is unchanged]
BUG=456494,457700
TBR=torne@chromium.org
Review URL: https://codereview.chromium.org/1159773002
Cr-Commit-Position: refs/heads/master@{#331341}
Diffstat (limited to 'android_webview/crash_reporter')
| -rw-r--r-- | android_webview/crash_reporter/aw_microdump_crash_reporter.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc index 016288a..ebb4fa0 100644 --- a/android_webview/crash_reporter/aw_microdump_crash_reporter.cc +++ b/android_webview/crash_reporter/aw_microdump_crash_reporter.cc @@ -4,6 +4,7 @@ #include "android_webview/crash_reporter/aw_microdump_crash_reporter.h" +#include "android_webview/common/aw_version_info_values.h" #include "base/lazy_instance.h" #include "build/build_config.h" #include "components/crash/app/breakpad_linux.h" @@ -22,6 +23,11 @@ class AwCrashReporterClient : public ::crash_reporter::CrashReporterClient { bool IsRunningUnattended() override { return false; } bool GetCollectStatsConsent() override { return false; } + void GetProductNameAndVersion(const char** product_name, + const char** version) override { + *product_name = "WebView"; + *version = PRODUCT_VERSION; + } // Microdumps are always enabled in WebView builds, conversely to what happens // in the case of the other Chrome for Android builds (where they are enabled // only when NO_UNWIND_TABLES == 1). |