summaryrefslogtreecommitdiffstats
path: root/android_webview/javatests
diff options
context:
space:
mode:
authorboliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-21 20:39:50 +0000
committerboliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-21 20:39:50 +0000
commitd37bbfe8e51d90cf795d95d9d28900f688ded1dc (patch)
treeaf531df08a605d497b941d25ca62857a918ee997 /android_webview/javatests
parent8ef02c246c47ad1120b841d359693dec84cd27a6 (diff)
downloadchromium_src-d37bbfe8e51d90cf795d95d9d28900f688ded1dc.zip
chromium_src-d37bbfe8e51d90cf795d95d9d28900f688ded1dc.tar.gz
chromium_src-d37bbfe8e51d90cf795d95d9d28900f688ded1dc.tar.bz2
Speculative temporary workaround to make Android Release bot green
It appears there is some hardware detection happening only release that is blocking the test for 60 seconds. This only happens once per apk install so only adding 60 seconds overall (not per test) delay to the release bot. See bug for full details. R=joth@chromium.org BUG=167236 Only increasing timeout on android webview tests. Ran through the android trybot. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11662012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174446 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview/javatests')
-rw-r--r--android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java3
-rw-r--r--android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java49
2 files changed, 14 insertions, 38 deletions
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
index 89f477e..408c2d3 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java
@@ -36,7 +36,8 @@ import java.util.concurrent.TimeUnit;
*/
public class AndroidWebViewTestBase
extends ActivityInstrumentationTestCase2<AndroidWebViewTestRunnerActivity> {
- protected static int WAIT_TIMEOUT_SECONDS = 15;
+ // TODO(boliu): Revert back to 15 seconds after crbug.com/167236 is fixed.
+ protected static int WAIT_TIMEOUT_SECONDS = 90;
private static final int CHECK_INTERVAL = 100;
protected static final boolean NORMAL_VIEW = false;
protected static final boolean INCOGNITO_VIEW = true;
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index 800e412..e9117a9 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -16,7 +16,6 @@ import org.chromium.android_webview.AwContents;
import org.chromium.android_webview.AwSettings;
import org.chromium.android_webview.test.util.CommonResources;
import org.chromium.android_webview.test.util.ImagePageGenerator;
-import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.TestFileUtil;
import org.chromium.base.test.util.UrlUtils;
@@ -1695,12 +1694,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
views.getClient1()));
}
- /*
- * @SmallTest
- * @Feature({"AndroidWebView", "Preferences"})
- * crbug.com/167236
- */
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
public void testFileUrlAccessNormal() throws Throwable {
ViewPair views = createViews(NORMAL_VIEW, NORMAL_VIEW);
runPerViewSettingsTest(
@@ -1708,12 +1703,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
new AwSettingsFileUrlAccessTestHelper(views.getContents1(), views.getClient1(), 1));
}
- /*
- * @SmallTest
- * @Feature({"AndroidWebView", "Preferences"})
- * crbug.com/167236
- */
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
public void testFileUrlAccessIncognito() throws Throwable {
ViewPair views = createViews(INCOGNITO_VIEW, INCOGNITO_VIEW);
runPerViewSettingsTest(
@@ -1721,12 +1712,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
new AwSettingsFileUrlAccessTestHelper(views.getContents1(), views.getClient1(), 1));
}
- /*
- * @SmallTest
- * @Feature({"AndroidWebView", "Preferences"})
- * crbug.com/167236
- */
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
public void testFileUrlAccessBoth() throws Throwable {
ViewPair views = createViews(NORMAL_VIEW, INCOGNITO_VIEW);
runPerViewSettingsTest(
@@ -2091,12 +2078,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
new AwSettingsJavaScriptPopupsTestHelper(views.getContents1(), views.getClient1()));
}
- /*
- * @SmallTest
- * @Feature({"AndroidWebView", "Preferences"})
- * crbug.com/167236
- */
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
public void testJavaScriptPopupsIncognito() throws Throwable {
ViewPair views = createViews(INCOGNITO_VIEW, INCOGNITO_VIEW);
runPerViewSettingsTest(
@@ -2104,12 +2087,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
new AwSettingsJavaScriptPopupsTestHelper(views.getContents1(), views.getClient1()));
}
- /*
- * @SmallTest
- * @Feature({"AndroidWebView", "Preferences"})
- * crbug.com/167236
- */
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
public void testJavaScriptPopupsBoth() throws Throwable {
ViewPair views = createViews(NORMAL_VIEW, INCOGNITO_VIEW);
runPerViewSettingsTest(
@@ -2214,12 +2193,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
}
}
- /*
- * @SmallTest
- * @Feature({"AndroidWebView", "Preferences"})
- * crbug.com/167236
- */
- @DisabledTest
+ @SmallTest
+ @Feature({"AndroidWebView", "Preferences"})
public void testCacheModeNormal() throws Throwable {
ViewPair views = createViews(NORMAL_VIEW, NORMAL_VIEW);
TestWebServer webServer = null;