diff options
| author | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-01 05:04:28 +0000 |
|---|---|---|
| committer | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-01 05:04:28 +0000 |
| commit | e1f4c6bc7309bc536ce2d0700941db111bf1145a (patch) | |
| tree | 576b1e6f97f7a189b8f837495e37d296db091718 /android_webview/lib | |
| parent | cde18a2d72ff1f7145446fe3f060f4bc4b89d6b0 (diff) | |
| download | chromium_src-e1f4c6bc7309bc536ce2d0700941db111bf1145a.zip chromium_src-e1f4c6bc7309bc536ce2d0700941db111bf1145a.tar.gz chromium_src-e1f4c6bc7309bc536ce2d0700941db111bf1145a.tar.bz2 | |
Revert of Disable speech synthesis API for content/ layer. (https://codereview.chromium.org/355183002/)
Reason for revert:
This breaks layout tests that are enumerating window properties:
PASS window.cached_scrollbars.visible is false
-PASS window.cached_speechSynthesis.onvoiceschanged is null
-PASS window.cached_speechSynthesis.paused is false
-PASS window.cached_speechSynthesis.pending is false
-PASS window.cached_speechSynthesis.speaking is false
PASS window.cached_statusbar.visible is false
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html,fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html,fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html,fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html,fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html,fast/dom/Window/property-access-on-cached-window-after-frame-removed.html,fast/speechsynthesis/speech-synthesis-boundary-events.html,fast/speechsynthesis/speech-synthesis-cancel-twice.html,fast/speechsynthesis/speech-synthesis-cancel.html,fast/speechsynthesis/speech-synthesis-gc-utterance-crash.html,fast/speechsynthesis/speech-synthesis-pause-resume.html,fast/speechsynthesis/speech-synthesis-speak-invalid-argument-throws.html,fast/speechsynthesis/speech-synthesis-speak.html,fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html,fast/speechsynthesis/speech-synthesis-voices-changed.html,fast/speechsynthesis/speech-synthesis-voices.html,virtual/stable/webexposed/global-constructors-listing.html,webexposed/global-constructors-listing.html
Original issue's description:
> Disable speech synthesis API for content/ layer.
>
> The Speech Synthesis API relies on an implementation in chrome/
> yet is a stable Web Platform feature so enabled in the content/
> layer. Flip the enable flag to a disable flag, and set it for
> non-chrome content/ embedders.
>
> BUG=347045
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280667
TBR=dmazzoni@chromium.org,brettw@chromium.org,benm@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347045
Review URL: https://codereview.chromium.org/359413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280749 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview/lib')
| -rw-r--r-- | android_webview/lib/main/aw_main_delegate.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc index 84b37ae..5f1069f 100644 --- a/android_webview/lib/main/aw_main_delegate.cc +++ b/android_webview/lib/main/aw_main_delegate.cc @@ -75,10 +75,6 @@ bool AwMainDelegate::BasicStartupComplete(int* exit_code) { // WebRTC hardware decoding is not supported, internal bug 15075307 cl->AppendSwitch(switches::kDisableWebRtcHWDecoding); - - // Speech Synthesis backend resides in the chrome layer, not used by WebView. - // http://crbug.com/347045 tracks moving the backend to the content layer. - cl->AppendSwitch(switches::kDisableSpeechSynthesis); return false; } |