diff options
| author | gab <gab@chromium.org> | 2014-12-08 13:54:09 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-08 21:54:30 +0000 |
| commit | ce7cfee334855215412460f91fd4d0f29b5e4afb (patch) | |
| tree | 622bd71263d1f5e7e9081d180147d3a1938bb437 /android_webview/native/aw_autofill_client.h | |
| parent | 6b150518257d898af57991939f9481bc3e95b5e7 (diff) | |
| download | chromium_src-ce7cfee334855215412460f91fd4d0f29b5e4afb.zip chromium_src-ce7cfee334855215412460f91fd4d0f29b5e4afb.tar.gz chromium_src-ce7cfee334855215412460f91fd4d0f29b5e4afb.tar.bz2 | |
Revert of Revert of Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (patchset #1 id:1 of https://codereview.chromium.org/790543002/)
Reason for revert:
Re-landing, revert didn't fix Win7 bots..
Original issue's description:
> Revert of Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (patchset #2 id:20001 of https://codereview.chromium.org/780423002/)
>
> Reason for revert:
> Suspected cause of flakines on Win7-bots, see http://crbug.com/440060 for details.
>
> Original issue's description:
> > Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate
> >
> > It was only by luck that this used to work. After a recent refactoring, the destruction order changed and the AutofillMetrics object no longer outlasts the infobar. AutofillMetrics doesn't need to be an instance object; make the relevant function a static instead.
> >
> > TBR=sgurun@chromium.org
> > BUG=439551, 439620
> >
> > Committed: https://crrev.com/19ece1e4af5207b92c2152395dfccca1683504e1
> > Cr-Commit-Position: refs/heads/master@{#307128}
>
> TBR=isherman@chromium.org,pkasting@chromium.org,estade@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=439551, 439620
>
> Committed: https://crrev.com/051aca46ed1dec4f040c9a3d7dac2af60df2db6c
> Cr-Commit-Position: refs/heads/master@{#307303}
TBR=isherman@chromium.org,pkasting@chromium.org,estade@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=439551, 439620, 440060
Review URL: https://codereview.chromium.org/782353002
Cr-Commit-Position: refs/heads/master@{#307345}
Diffstat (limited to 'android_webview/native/aw_autofill_client.h')
| -rw-r--r-- | android_webview/native/aw_autofill_client.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/android_webview/native/aw_autofill_client.h b/android_webview/native/aw_autofill_client.h index c328d56..96a86e1 100644 --- a/android_webview/native/aw_autofill_client.h +++ b/android_webview/native/aw_autofill_client.h @@ -62,7 +62,6 @@ class AwAutofillClient : public autofill::AutofillClient, virtual void HideRequestAutocompleteDialog() override; virtual void ShowAutofillSettings() override; virtual void ConfirmSaveCreditCard( - const autofill::AutofillMetrics& metric_logger, const base::Closure& save_card_callback) override; virtual bool HasCreditCardScanFeature() override; virtual void ScanCreditCard(const CreditCardScanCallback& callback) override; |