diff options
| author | boliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-26 06:39:28 +0000 |
|---|---|---|
| committer | boliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-26 06:39:28 +0000 |
| commit | 628e3539f3caf339af7b30e885e713176bae823c (patch) | |
| tree | fd5cb572ea42aea19afbed12988847d130fe272a /android_webview/native/aw_dev_tools_server.cc | |
| parent | 3a00ccc0450c037167aea4feb765e590202fc642 (diff) | |
| download | chromium_src-628e3539f3caf339af7b30e885e713176bae823c.zip chromium_src-628e3539f3caf339af7b30e885e713176bae823c.tar.gz chromium_src-628e3539f3caf339af7b30e885e713176bae823c.tar.bz2 | |
aw: Fix hardware teardown race
Reading IsHardwareInitialized in OnDetachedFromWindow on the UI thread
is unsafe as it can change after being read. Remove it and use whether
UI has hardware initialized instead.
BUG=388890
Review URL: https://codereview.chromium.org/348613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279934 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview/native/aw_dev_tools_server.cc')
| -rw-r--r-- | android_webview/native/aw_dev_tools_server.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/android_webview/native/aw_dev_tools_server.cc b/android_webview/native/aw_dev_tools_server.cc index 6890655..6783bae 100644 --- a/android_webview/native/aw_dev_tools_server.cc +++ b/android_webview/native/aw_dev_tools_server.cc @@ -144,7 +144,7 @@ std::string GetViewDescription(WebContents* web_contents) { ->GetBrowserViewRenderer(); if (!bvr) return ""; base::DictionaryValue description; - description.SetBoolean("attached", bvr->IsAttachedToWindow()); + description.SetBoolean("attached", bvr->attached_to_window()); description.SetBoolean("visible", bvr->IsVisible()); gfx::Rect screen_rect = bvr->GetScreenRect(); description.SetInteger("screenX", screen_rect.x()); |