diff options
author | sgurun@chromium.org <sgurun@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-23 08:46:44 +0000 |
---|---|---|
committer | sgurun@chromium.org <sgurun@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-23 08:46:44 +0000 |
commit | cfc5f4162cfa5fed65d040e28cac41741ac79116 (patch) | |
tree | bbf12950200c003a6f1b27cc5676777e9a5f94f3 /android_webview/native | |
parent | 8d0cdb7ea233cb8a620b79379700be499b05e528 (diff) | |
download | chromium_src-cfc5f4162cfa5fed65d040e28cac41741ac79116.zip chromium_src-cfc5f4162cfa5fed65d040e28cac41741ac79116.tar.gz chromium_src-cfc5f4162cfa5fed65d040e28cac41741ac79116.tar.bz2 |
Post the callback methods on correct thread and address some nits
BUG=b/12983007
Review URL: https://codereview.chromium.org/247063008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265584 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview/native')
-rw-r--r-- | android_webview/native/aw_contents_client_bridge.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/android_webview/native/aw_contents_client_bridge.cc b/android_webview/native/aw_contents_client_bridge.cc index 0703c81..efb5a85 100644 --- a/android_webview/native/aw_contents_client_bridge.cc +++ b/android_webview/native/aw_contents_client_bridge.cc @@ -31,6 +31,7 @@ namespace android_webview { typedef net::OpenSSLClientKeyStore::ScopedEVP_PKEY ScopedEVP_PKEY; namespace { + // Must be called on the I/O thread to record a client certificate // and its private key in the OpenSSLClientKeyStore. void RecordClientCertificateKey( @@ -130,8 +131,8 @@ void AwContentsClientBridge::SelectClientCertificate( // Build the |key_types| JNI parameter, as a String[] std::vector<std::string> key_types; - for (size_t n = 0; n < cert_request_info->cert_key_types.size(); ++n) { - switch (cert_request_info->cert_key_types[n]) { + for (size_t i = 0; i < cert_request_info->cert_key_types.size(); ++i) { + switch (cert_request_info->cert_key_types[i]) { case net::CLIENT_CERT_RSA_SIGN: key_types.push_back("RSA"); break; @@ -213,8 +214,8 @@ void AwContentsClientBridge::ProvideClientCertificateResponse( } std::vector<base::StringPiece> encoded_chain; - for (size_t n = 0; n < encoded_chain_strings.size(); ++n) - encoded_chain.push_back(encoded_chain_strings[n]); + for (size_t i = 0; i < encoded_chain_strings.size(); ++i) + encoded_chain.push_back(encoded_chain_strings[i]); // Create the X509Certificate object from the encoded chain. scoped_refptr<net::X509Certificate> client_cert( |