diff options
author | benm@chromium.org <benm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 18:43:47 +0000 |
---|---|---|
committer | benm@chromium.org <benm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-04 18:43:47 +0000 |
commit | 8c6b319b0be38d10350a95d4c2cb30b2239536ee (patch) | |
tree | 64c0afd002593b7340fba082b8e32f04f0f46bec /android_webview | |
parent | 47257379eee0f8e00bea673148ba23dfe3451007 (diff) | |
download | chromium_src-8c6b319b0be38d10350a95d4c2cb30b2239536ee.zip chromium_src-8c6b319b0be38d10350a95d4c2cb30b2239536ee.tar.gz chromium_src-8c6b319b0be38d10350a95d4c2cb30b2239536ee.tar.bz2 |
[Android WebView] Remove unnecessary DCHECK in InputStreamImpl.
Follow up post-review comments on change
https://src.chromium.org/viewvc/chrome?view=rev&revision=174967
See https://codereview.chromium.org/11748015/ for more information.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11748032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175159 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview')
-rw-r--r-- | android_webview/native/input_stream_impl.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/android_webview/native/input_stream_impl.cc b/android_webview/native/input_stream_impl.cc index 5272ee54..515cb51 100644 --- a/android_webview/native/input_stream_impl.cc +++ b/android_webview/native/input_stream_impl.cc @@ -37,6 +37,9 @@ const InputStreamImpl* InputStreamImpl::FromInputStream( return static_cast<const InputStreamImpl*>(input_stream); } +// TODO: Use unsafe version for all Java_InputStream methods in this file +// once BUG 157880 is fixed and implement graceful exception handling. + InputStreamImpl::InputStreamImpl() { } @@ -48,13 +51,10 @@ InputStreamImpl::InputStreamImpl(const JavaRef<jobject>& stream) InputStreamImpl::~InputStreamImpl() { JNIEnv* env = AttachCurrentThread(); Java_InputStream_close(env, jobject_.obj()); - DCHECK(!ClearException(env)); } bool InputStreamImpl::BytesAvailable(int* bytes_available) const { JNIEnv* env = AttachCurrentThread(); - // TODO: Use unsafe version for all Java_InputStream methods in this file - // once BUG 157880 is fixed. int bytes = Java_InputStream_available(env, jobject_.obj()); if (ClearException(env)) return false; |