summaryrefslogtreecommitdiffstats
path: root/android_webview
diff options
context:
space:
mode:
authorstanisc <stanisc@chromium.org>2015-03-17 08:42:03 -0700
committerCommit bot <commit-bot@chromium.org>2015-03-17 15:42:46 +0000
commit12cf7b569a3dc4cbf0f5ee88377bae8e47fc6653 (patch)
tree1708b8942569a671fad1a1367d33a23e37778b7e /android_webview
parent956d30cb23b16161170a91d5fcaa316bc0b0eaab (diff)
downloadchromium_src-12cf7b569a3dc4cbf0f5ee88377bae8e47fc6653.zip
chromium_src-12cf7b569a3dc4cbf0f5ee88377bae8e47fc6653.tar.gz
chromium_src-12cf7b569a3dc4cbf0f5ee88377bae8e47fc6653.tar.bz2
Sync: Handle empty (implicit) ParentId in GetPredecessorId and GetSuccessorId
GetSuccessorId and GetPredecessorId access all children of the current node's parent in order to get to the next/previous node. With implicit parent ID these functions can't get to the parent. The reasons we didn't run into this problem before are a) The server feature that will stop setting parent ID isn't enabled yet so there wasn't a chance to expose this yet. b) There wasn't enough test coverage. The fix is to use the ParentChildIndex to resolve the implicit (unset) parent ID. Added a new method called GetSiblings at the Directory level that does just that. Also added some unit test coverage. BUG=438313 Review URL: https://codereview.chromium.org/1008993004 Cr-Commit-Position: refs/heads/master@{#320922}
Diffstat (limited to 'android_webview')
0 files changed, 0 insertions, 0 deletions