diff options
| author | estade <estade@chromium.org> | 2014-12-05 16:48:43 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-06 00:49:12 +0000 |
| commit | 19ece1e4af5207b92c2152395dfccca1683504e1 (patch) | |
| tree | 106a49be7b70b8a2dff281b000b4b8fd79eefe1d /android_webview | |
| parent | 3e6a644d0c05a1147fd093f12447a82ad4768c32 (diff) | |
| download | chromium_src-19ece1e4af5207b92c2152395dfccca1683504e1.zip chromium_src-19ece1e4af5207b92c2152395dfccca1683504e1.tar.gz chromium_src-19ece1e4af5207b92c2152395dfccca1683504e1.tar.bz2 | |
Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate
It was only by luck that this used to work. After a recent refactoring, the destruction order changed and the AutofillMetrics object no longer outlasts the infobar. AutofillMetrics doesn't need to be an instance object; make the relevant function a static instead.
TBR=sgurun@chromium.org
BUG=439551, 439620
Review URL: https://codereview.chromium.org/780423002
Cr-Commit-Position: refs/heads/master@{#307128}
Diffstat (limited to 'android_webview')
| -rw-r--r-- | android_webview/native/aw_autofill_client.cc | 1 | ||||
| -rw-r--r-- | android_webview/native/aw_autofill_client.h | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/android_webview/native/aw_autofill_client.cc b/android_webview/native/aw_autofill_client.cc index 95f3fd5..de1d1ef 100644 --- a/android_webview/native/aw_autofill_client.cc +++ b/android_webview/native/aw_autofill_client.cc @@ -188,7 +188,6 @@ void AwAutofillClient::ShowAutofillSettings() { } void AwAutofillClient::ConfirmSaveCreditCard( - const autofill::AutofillMetrics& metric_logger, const base::Closure& save_card_callback) { NOTIMPLEMENTED(); } diff --git a/android_webview/native/aw_autofill_client.h b/android_webview/native/aw_autofill_client.h index c328d56..96a86e1 100644 --- a/android_webview/native/aw_autofill_client.h +++ b/android_webview/native/aw_autofill_client.h @@ -62,7 +62,6 @@ class AwAutofillClient : public autofill::AutofillClient, virtual void HideRequestAutocompleteDialog() override; virtual void ShowAutofillSettings() override; virtual void ConfirmSaveCreditCard( - const autofill::AutofillMetrics& metric_logger, const base::Closure& save_card_callback) override; virtual bool HasCreditCardScanFeature() override; virtual void ScanCreditCard(const CreditCardScanCallback& callback) override; |