summaryrefslogtreecommitdiffstats
path: root/android_webview
diff options
context:
space:
mode:
authorcreis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-05 23:24:29 +0000
committercreis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-05 23:24:29 +0000
commit5027949d2b3b0e39a7ea16fcfef9a2984cf0298a (patch)
tree8e4ff52aaea7141ec9e60cace882190a6305cc92 /android_webview
parent8aadf0361638727bbc0dc481e328cd8b25cf7eec (diff)
downloadchromium_src-5027949d2b3b0e39a7ea16fcfef9a2984cf0298a.zip
chromium_src-5027949d2b3b0e39a7ea16fcfef9a2984cf0298a.tar.gz
chromium_src-5027949d2b3b0e39a7ea16fcfef9a2984cf0298a.tar.bz2
Remove page IDs from three WebContentsObserver APIs that don't need it.
Page IDs are not safe to use on their own, without knowing which SiteInstance they correspond to. BUG=369661 TEST=Dead code, no behavior change. TBR=jam TBR=mkosiba Review URL: https://codereview.chromium.org/266053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268312 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview')
-rw-r--r--android_webview/browser/icon_helper.cc2
-rw-r--r--android_webview/browser/icon_helper.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc
index cc5ae42..8922a7e 100644
--- a/android_webview/browser/icon_helper.cc
+++ b/android_webview/browser/icon_helper.cc
@@ -57,7 +57,7 @@ void IconHelper::DownloadFaviconCallback(
listener_->OnReceivedIcon(image_url, bitmaps[0]);
}
-void IconHelper::DidUpdateFaviconURL(int32 page_id,
+void IconHelper::DidUpdateFaviconURL(
const std::vector<content::FaviconURL>& candidates) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
for (std::vector<content::FaviconURL>::const_iterator i = candidates.begin();
diff --git a/android_webview/browser/icon_helper.h b/android_webview/browser/icon_helper.h
index 13caefe..f325450 100644
--- a/android_webview/browser/icon_helper.h
+++ b/android_webview/browser/icon_helper.h
@@ -42,7 +42,7 @@ class IconHelper : public content::WebContentsObserver {
void SetListener(Listener* listener);
// From WebContentsObserver
- virtual void DidUpdateFaviconURL(int32 page_id,
+ virtual void DidUpdateFaviconURL(
const std::vector<content::FaviconURL>& candidates) OVERRIDE;
virtual void DidStartNavigationToPendingEntry(
const GURL& url,