diff options
| author | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-13 23:25:12 +0000 |
|---|---|---|
| committer | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-13 23:25:12 +0000 |
| commit | fed0d1ca028c4715ab0dcba188596ae29d5e3ad3 (patch) | |
| tree | 5ff8af79144cd07307e44cd1965dbdea276dfcde /android_webview | |
| parent | 45c2428c0c3b8bda0f40aac07d1ef0f27e35fe2f (diff) | |
| download | chromium_src-fed0d1ca028c4715ab0dcba188596ae29d5e3ad3.zip chromium_src-fed0d1ca028c4715ab0dcba188596ae29d5e3ad3.tar.gz chromium_src-fed0d1ca028c4715ab0dcba188596ae29d5e3ad3.tar.bz2 | |
Cleanup CanDownload WebContentsDelegate API
It seems we were passing an opaque request ID in WebContentsDelegate::CanDownload
that wasn't used anywhere. Instead, for <webview>, we would simply like the URL
that generated the download request. This CL simplifies the API and reduces cruft
and code complexity
BUG=364141, 330264
TBR=sgurun@chromium.org
Review URL: https://codereview.chromium.org/286543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270242 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'android_webview')
| -rw-r--r-- | android_webview/native/aw_web_contents_delegate.cc | 2 | ||||
| -rw-r--r-- | android_webview/native/aw_web_contents_delegate.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc index c91f6d3..f9c42b1 100644 --- a/android_webview/native/aw_web_contents_delegate.cc +++ b/android_webview/native/aw_web_contents_delegate.cc @@ -76,7 +76,7 @@ void AwWebContentsDelegate::FindReply(WebContents* web_contents, void AwWebContentsDelegate::CanDownload( content::RenderViewHost* source, - int request_id, + const GURL& url, const std::string& request_method, const base::Callback<void(bool)>& callback) { // Android webview intercepts download in its resource dispatcher host diff --git a/android_webview/native/aw_web_contents_delegate.h b/android_webview/native/aw_web_contents_delegate.h index dce3fa7..1954bc2 100644 --- a/android_webview/native/aw_web_contents_delegate.h +++ b/android_webview/native/aw_web_contents_delegate.h @@ -28,7 +28,7 @@ class AwWebContentsDelegate int active_match_ordinal, bool final_update) OVERRIDE; virtual void CanDownload(content::RenderViewHost* source, - int request_id, + const GURL& url, const std::string& request_method, const base::Callback<void(bool)>& callback) OVERRIDE; virtual void RunFileChooser( |