diff options
author | jshin@chromium.org <jshin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-18 05:12:29 +0000 |
---|---|---|
committer | jshin@chromium.org <jshin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-18 05:12:29 +0000 |
commit | b5b2385af64eb08b1feb53fb0ad65c835f472912 (patch) | |
tree | 6af57cd4a4965cebe2107e07ca8e563444c3afe9 /app/gfx | |
parent | 80d6524d33061e0e4f7b06dd87ee94de3e05c7a8 (diff) | |
download | chromium_src-b5b2385af64eb08b1feb53fb0ad65c835f472912.zip chromium_src-b5b2385af64eb08b1feb53fb0ad65c835f472912.tar.gz chromium_src-b5b2385af64eb08b1feb53fb0ad65c835f472912.tar.bz2 |
Use 'icu::' namespace explicitly throughout Chrome tree instead of relying on 'using namespace icu'.
This is Chrome's counterpart to the ICU header change that disables
'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece.
The webkit change (which is minor) will be dealt with in the webkit bugzilla.
This can go in before the ICU change/upgrade without affecting anything.
BUG=8198
TEST=All the targets are built without an error on all platforms.
Review URL: http://codereview.chromium.org/171012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app/gfx')
-rw-r--r-- | app/gfx/text_elider.cc | 2 | ||||
-rw-r--r-- | app/gfx/text_elider.h | 2 | ||||
-rw-r--r-- | app/gfx/text_elider_unittest.cc | 3 |
3 files changed, 4 insertions, 3 deletions
diff --git a/app/gfx/text_elider.cc b/app/gfx/text_elider.cc index 72ee61d..7f56fac 100644 --- a/app/gfx/text_elider.cc +++ b/app/gfx/text_elider.cc @@ -337,7 +337,7 @@ SortedDisplayURL::SortedDisplayURL(const GURL& url, } int SortedDisplayURL::Compare(const SortedDisplayURL& other, - Collator* collator) const { + icu::Collator* collator) const { // Compare on hosts first. The host won't contain 'www.'. UErrorCode compare_status = U_ZERO_ERROR; UCollationResult host_compare_result = collator->compare( diff --git a/app/gfx/text_elider.h b/app/gfx/text_elider.h index 96afdfb..4c9c1fa 100644 --- a/app/gfx/text_elider.h +++ b/app/gfx/text_elider.h @@ -60,7 +60,7 @@ class SortedDisplayURL { // Compares this SortedDisplayURL to |url| using |collator|. Returns a value // < 0, = 1 or > 0 as to whether this url is less then, equal to or greater // than the supplied url. - int Compare(const SortedDisplayURL& other, Collator* collator) const; + int Compare(const SortedDisplayURL& other, icu::Collator* collator) const; // Returns the display string for the URL. const string16& display_url() const { return display_url_; } diff --git a/app/gfx/text_elider_unittest.cc b/app/gfx/text_elider_unittest.cc index 03e0bad..bf07428 100644 --- a/app/gfx/text_elider_unittest.cc +++ b/app/gfx/text_elider_unittest.cc @@ -234,7 +234,8 @@ TEST(TextEliderTest, SortedDisplayURL) { // Verifies DisplayURL::Compare works correctly. TEST(TextEliderTest, SortedDisplayURLCompare) { UErrorCode create_status = U_ZERO_ERROR; - scoped_ptr<Collator> collator(Collator::createInstance(create_status)); + scoped_ptr<icu::Collator> collator( + icu::Collator::createInstance(create_status)); if (!U_SUCCESS(create_status)) return; |