Make DevTools open docked by default for chrome os.

- Change prefs::kDevToolsOpenDocked default to "true" for chrome os;
- Fix a problem on chrome os that DevTools occupies the whole client area.
  This is because BrowserView::Show is called before gtk size allocated
  event and thus divider offset is calculated wrongly to 0. The fix is
  to move the "restore split offset" logic to UpdateDevToolsForContents
  before we do contents_split_ layout for show up DevTools;
- Fix a problem that DevTools becomes invisible after undock then dock
  for linux toolkit_view/chromeos build. This is because
  browser/views/tab_contents/TabContentsViewGtk does not show/hide its
  contained TabContents like TabContentsViewWin. As mentioned in
  BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up
  gtk show/hide signal and notify the contained TabContents about the
  visibility change. After the fix, remove the manual ShowContents for
  DevTools in BrowserWindowGtk::UpdateDevToolsForContents.

<http://crosbug.com/333>

BUG=333
TEST=Verify that DevTools show up as docked by default.

Review URL: http://codereview.chromium.org/880003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 10 insertions, 10 deletions

diff --git a/app/gtk_signal.h b/app/gtk_signal.h
index e56c75d..c21ef81 100644
--- a/app/gtk_signal.h
+++ b/app/gtk_signal.h
@@ -26,7 +26,7 @@ typedef struct _GtkWidget GtkWidget;
     return reinterpret_cast<TYPE*>(userdata)->METHOD(widget);           \
   }                                                                     \
                                                                         \
-  RETURN METHOD(GtkWidget* widget);
+  virtual RETURN METHOD(GtkWidget* widget);
 
 #define CHROMEGTK_CALLBACK_1(TYPE, RETURN, METHOD, ARG1)            \
   static RETURN METHOD ## Thunk(GtkWidget* widget, ARG1 one,        \
@@ -34,7 +34,7 @@ typedef struct _GtkWidget GtkWidget;
     return reinterpret_cast<TYPE*>(userdata)->METHOD(widget, one);  \
   }                                                                 \
                                                                     \
-  RETURN METHOD(GtkWidget* widget, ARG1 one);
+  virtual RETURN METHOD(GtkWidget* widget, ARG1 one);
 
 #define CHROMEGTK_CALLBACK_2(TYPE, RETURN, METHOD, ARG1, ARG2)          \
   static RETURN METHOD ## Thunk(GtkWidget* widget, ARG1 one, ARG2 two,  \
@@ -42,7 +42,7 @@ typedef struct _GtkWidget GtkWidget;
     return reinterpret_cast<TYPE*>(userdata)->METHOD(widget, one, two); \
   }                                                                     \
                                                                         \
-  RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two);
+  virtual RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two);
 
 #define CHROMEGTK_CALLBACK_3(TYPE, RETURN, METHOD, ARG1, ARG2, ARG3)    \
   static RETURN METHOD ## Thunk(GtkWidget* widget, ARG1 one, ARG2 two,  \
@@ -51,7 +51,7 @@ typedef struct _GtkWidget GtkWidget;
         METHOD(widget, one, two, three);                                \
   }                                                                     \
                                                                         \
-  RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two, ARG3 three);
+  virtual RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two, ARG3 three);
 
 #define CHROMEGTK_CALLBACK_4(TYPE, RETURN, METHOD, ARG1, ARG2, ARG3, ARG4) \
   static RETURN METHOD ## Thunk(GtkWidget* widget, ARG1 one, ARG2 two,  \
@@ -61,8 +61,8 @@ typedef struct _GtkWidget GtkWidget;
         METHOD(widget, one, two, three, four);                          \
   }                                                                     \
                                                                         \
-  RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two, ARG3 three,      \
-                ARG4 four);
+  virtual RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two,          \
+                        ARG3 three, ARG4 four);
 
 #define CHROMEGTK_CALLBACK_5(TYPE, RETURN, METHOD, ARG1, ARG2, ARG3, ARG4, \
                              ARG5)                                      \
@@ -73,8 +73,8 @@ typedef struct _GtkWidget GtkWidget;
         METHOD(widget, one, two, three, four, five);                    \
   }                                                                     \
                                                                         \
-  RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two, ARG3 three,      \
-                ARG4 four, ARG5 five);
+  virtual RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two,          \
+                        ARG3 three, ARG4 four, ARG5 five);
 
 #define CHROMEGTK_CALLBACK_6(TYPE, RETURN, METHOD, ARG1, ARG2, ARG3, ARG4, \
                              ARG5, ARG6)                                \
@@ -85,7 +85,7 @@ typedef struct _GtkWidget GtkWidget;
         METHOD(widget, one, two, three, four, five, six);               \
   }                                                                     \
                                                                         \
-  RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two, ARG3 three,      \
-                ARG4 four, ARG5 five, ARG6 six);
+  virtual RETURN METHOD(GtkWidget* widget, ARG1 one, ARG2 two,          \
+                        ARG3 three, ARG4 four, ARG5 five, ARG6 six);
 
 #endif  // APP_GTK_SIGNAL_H_