Setting the ICU default locale is made explicit. This leads to a few more

lines of code, but I think it'd be better this way. Setting the ICU
default locale 'quitely' as a part of IsLocaleAvailable is partly responsible for bug 26856. 
With the fix for that bug, Mac Chrome sets the ICU default locale explicitly.
Putting Linux/Windows on the same footing is a "good thing" (TM). 

In addition, I fixed a typo (a spurrious L modifier to a char literal) and
resolved one TODO comment (use uloc_getCharacterOrientation to determine
the text layout direction).

BUG=NONE
TEST=Covered by unittests: L10nUtilTest.*

Review URL: http://codereview.chromium.org/449077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33646 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 4 deletions

diff --git a/app/l10n_util_unittest.cc b/app/l10n_util_unittest.cc
index 0298988..489e725 100644
--- a/app/l10n_util_unittest.cc
+++ b/app/l10n_util_unittest.cc
@@ -477,12 +477,14 @@ TEST_F(L10nUtilTest, GetTextDirection) {
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("he_IL"));
   // iw is an obsolete code for Hebrew.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("iw"));
-#if 0
-  // Enable these when we localize to Farsi, Urdu, Azerbaijani
-  // written in Arabic and Dhivehi. At the moment, our copy of
-  // ICU data does not have entry for them.
+  // Although we're not yet localized to Farsi and Urdu, we
+  // do have the text layout direction information for them.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("fa"));
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("ur"));
+#if 0
+  // Enable these when we include the minimal locale data for Azerbaijani
+  // written in Arabic and Dhivehi. At the moment, our copy of
+  // ICU data does not have entries for them.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("az_Arab"));
   // Dhivehi that uses Thaana script.
   EXPECT_EQ(l10n_util::RIGHT_TO_LEFT, GetTextDirection("dv"));