summaryrefslogtreecommitdiffstats
path: root/app/l10n_util_unittest.cc
diff options
context:
space:
mode:
authoravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-28 16:55:57 +0000
committeravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-12-28 16:55:57 +0000
commitd223f3bfefc0c92a216f21c4d84e844bb663c2a6 (patch)
treef4982b4490fe13de645b445ab95f3c82c95cf8aa /app/l10n_util_unittest.cc
parentbf570fb6773be4e4082b73c5b7a32fff5dc6663b (diff)
downloadchromium_src-d223f3bfefc0c92a216f21c4d84e844bb663c2a6.zip
chromium_src-d223f3bfefc0c92a216f21c4d84e844bb663c2a6.tar.gz
chromium_src-d223f3bfefc0c92a216f21c4d84e844bb663c2a6.tar.bz2
Remove wstring from l10n_util. Part 1.
BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/5990008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70224 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app/l10n_util_unittest.cc')
-rw-r--r--app/l10n_util_unittest.cc40
1 files changed, 22 insertions, 18 deletions
diff --git a/app/l10n_util_unittest.cc b/app/l10n_util_unittest.cc
index 23ff698..b6c6b9b 100644
--- a/app/l10n_util_unittest.cc
+++ b/app/l10n_util_unittest.cc
@@ -32,11 +32,11 @@ namespace {
class StringWrapper {
public:
- explicit StringWrapper(const std::wstring& string) : string_(string) {}
- const std::wstring& string() const { return string_; }
+ explicit StringWrapper(const string16& string) : string_(string) {}
+ const string16& string() const { return string_; }
private:
- std::wstring string_;
+ string16 string_;
DISALLOW_COPY_AND_ASSIGN(StringWrapper);
};
@@ -49,14 +49,16 @@ class L10nUtilTest : public PlatformTest {
#if defined(OS_WIN)
// TODO(beng): disabled until app strings move to app.
TEST_F(L10nUtilTest, DISABLED_GetString) {
- std::wstring s = l10n_util::GetString(IDS_SIMPLE);
- EXPECT_EQ(std::wstring(L"Hello World!"), s);
+ std::string s = l10n_util::GetStringUTF8(IDS_SIMPLE);
+ EXPECT_EQ(std::string("Hello World!"), s);
- s = l10n_util::GetStringF(IDS_PLACEHOLDERS, L"chrome", L"10");
- EXPECT_EQ(std::wstring(L"Hello, chrome. Your number is 10."), s);
+ s = l10n_util::GetStringFUTF8(IDS_PLACEHOLDERS,
+ UTF8ToUTF16("chrome"),
+ UTF8ToUTF16("10"));
+ EXPECT_EQ(std::string("Hello, chrome. Your number is 10."), s);
- s = l10n_util::GetStringF(IDS_PLACEHOLDERS_2, 20);
- EXPECT_EQ(std::wstring(L"You owe me $20."), s);
+ string16 s16 = l10n_util::GetStringFUTF16(IDS_PLACEHOLDERS_2, 20);
+ EXPECT_EQ(UTF8ToUTF16("You owe me $20."), s16);
}
#endif // defined(OS_WIN)
@@ -285,15 +287,17 @@ TEST_F(L10nUtilTest, GetAppLocale) {
TEST_F(L10nUtilTest, SortStringsUsingFunction) {
std::vector<StringWrapper*> strings;
- strings.push_back(new StringWrapper(L"C"));
- strings.push_back(new StringWrapper(L"d"));
- strings.push_back(new StringWrapper(L"b"));
- strings.push_back(new StringWrapper(L"a"));
- l10n_util::SortStringsUsingMethod(L"en-US", &strings, &StringWrapper::string);
- ASSERT_TRUE(L"a" == strings[0]->string());
- ASSERT_TRUE(L"b" == strings[1]->string());
- ASSERT_TRUE(L"C" == strings[2]->string());
- ASSERT_TRUE(L"d" == strings[3]->string());
+ strings.push_back(new StringWrapper(UTF8ToUTF16("C")));
+ strings.push_back(new StringWrapper(UTF8ToUTF16("d")));
+ strings.push_back(new StringWrapper(UTF8ToUTF16("b")));
+ strings.push_back(new StringWrapper(UTF8ToUTF16("a")));
+ l10n_util::SortStringsUsingMethod("en-US",
+ &strings,
+ &StringWrapper::string);
+ ASSERT_TRUE(UTF8ToUTF16("a") == strings[0]->string());
+ ASSERT_TRUE(UTF8ToUTF16("b") == strings[1]->string());
+ ASSERT_TRUE(UTF8ToUTF16("C") == strings[2]->string());
+ ASSERT_TRUE(UTF8ToUTF16("d") == strings[3]->string());
STLDeleteElements(&strings);
}