summaryrefslogtreecommitdiffstats
path: root/app/menus
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-13 20:43:43 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-13 20:43:43 +0000
commit451371ef73d2b718758a210640d06fad0182ac7d (patch)
tree86a11a80ae430eab655983f387d6c6ce39ca9318 /app/menus
parent2cb1fa9f537b92908693eddc4489c38ab3318225 (diff)
downloadchromium_src-451371ef73d2b718758a210640d06fad0182ac7d.zip
chromium_src-451371ef73d2b718758a210640d06fad0182ac7d.tar.gz
chromium_src-451371ef73d2b718758a210640d06fad0182ac7d.tar.bz2
Only use IDC_ values for command ids in the render view context menu.
BUG=43816 TEST=none Review URL: http://codereview.chromium.org/1981014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47187 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app/menus')
-rw-r--r--app/menus/simple_menu_model.cc8
-rw-r--r--app/menus/simple_menu_model.h6
2 files changed, 0 insertions, 14 deletions
diff --git a/app/menus/simple_menu_model.cc b/app/menus/simple_menu_model.cc
index 0561c5a..8631666 100644
--- a/app/menus/simple_menu_model.cc
+++ b/app/menus/simple_menu_model.cc
@@ -28,10 +28,6 @@ void SimpleMenuModel::AddItemWithStringId(int command_id, int string_id) {
AddItem(command_id, l10n_util::GetStringUTF16(string_id));
}
-void SimpleMenuModel::AddItemIdentifiedByStringId(int string_id) {
- AddItemWithStringId(string_id, string_id);
-}
-
void SimpleMenuModel::AddSeparator() {
Item item = { kSeparatorId, string16(), SkBitmap(), TYPE_SEPARATOR, -1,
NULL };
@@ -47,10 +43,6 @@ void SimpleMenuModel::AddCheckItemWithStringId(int command_id, int string_id) {
AddCheckItem(command_id, l10n_util::GetStringUTF16(string_id));
}
-void SimpleMenuModel::AddCheckItemIdentifiedByStringId(int string_id) {
- AddCheckItemWithStringId(string_id, string_id);
-}
-
void SimpleMenuModel::AddRadioItem(int command_id, const string16& label,
int group_id) {
Item item = { command_id, label, SkBitmap(), TYPE_RADIO, group_id, NULL };
diff --git a/app/menus/simple_menu_model.h b/app/menus/simple_menu_model.h
index f183166b..8dd6c64 100644
--- a/app/menus/simple_menu_model.h
+++ b/app/menus/simple_menu_model.h
@@ -63,12 +63,6 @@ class SimpleMenuModel : public MenuModel {
void AddSubMenu(int command_id, const string16& label, MenuModel* model);
void AddSubMenuWithStringId(int command_id, int string_id, MenuModel* model);
- // Helpers for the above that use the |string_id| for the |command_id|
- // as well.
- // TODO(estade): remove these.
- void AddItemIdentifiedByStringId(int string_id);
- void AddCheckItemIdentifiedByStringId(int string_id);
-
// Methods for inserting items into the model.
void InsertItemAt(int index, int command_id, const string16& label);
void InsertItemWithStringIdAt(int index, int command_id, int string_id);