AppCacheDatabase and SQL based AppCacheStorageImpl.

Still nothing is being written to disk with this CL, 
in-memory SQLite and DiskCaches are being utilized. 
Responses are not yet being removed from the DiskCasche 
when the should be. Once that's done (in the next CL), we'll 
start saving things on disk. 

BUG=none 
TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc 

Review URL: http://codereview.chromium.org/518020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35354 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 9 insertions, 3 deletions

diff --git a/app/sql/meta_table.cc b/app/sql/meta_table.cc
index 03a1245..4d7c5e1 100644
--- a/app/sql/meta_table.cc
+++ b/app/sql/meta_table.cc
@@ -15,6 +15,12 @@ namespace sql {
 static const char kVersionKey[] = "version";
 static const char kCompatibleVersionKey[] = "last_compatible_version";
 
+// static
+bool MetaTable::DoesTableExist(sql::Connection* db) {
+  DCHECK(db);
+  return db->DoesTableExist("meta");
+}
+
 MetaTable::MetaTable() : db_(NULL) {
 }
 
@@ -24,7 +30,7 @@ MetaTable::~MetaTable() {
 bool MetaTable::Init(Connection* db, int version, int compatible_version) {
   DCHECK(!db_ && db);
   db_ = db;
-  if (!db_->DoesTableExist("meta")) {
+  if (!DoesTableExist(db)) {
     if (!db_->Execute("CREATE TABLE meta"
         "(key LONGVARCHAR NOT NULL UNIQUE PRIMARY KEY,"
          "value LONGVARCHAR)"))
@@ -117,7 +123,7 @@ bool MetaTable::PrepareSetStatement(Statement* statement, const char* key) {
   DCHECK(db_ && statement);
   statement->Assign(db_->GetCachedStatement(SQL_FROM_HERE,
       "INSERT OR REPLACE INTO meta (key,value) VALUES (?,?)"));
-  if (!*statement) {
+  if (!statement->is_valid()) {
     NOTREACHED() << db_->GetErrorMessage();
     return false;
   }
@@ -129,7 +135,7 @@ bool MetaTable::PrepareGetStatement(Statement* statement, const char* key) {
   DCHECK(db_ && statement);
   statement->Assign(db_->GetCachedStatement(SQL_FROM_HERE,
       "SELECT value FROM meta WHERE key=?"));
-  if (!*statement) {
+  if (!statement->is_valid()) {
     NOTREACHED() << db_->GetErrorMessage();
     return false;
   }