summaryrefslogtreecommitdiffstats
path: root/app/sql
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-28 22:54:58 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-28 22:54:58 +0000
commitd4799a3bf70ecc62ab702150cae1d1e925b14938 (patch)
treefae21bc09ddaa68dfc709e0d6abc55a43fe99333 /app/sql
parent7176ef1c7ada2da66a47ed38987c92a06f3bfb4a (diff)
downloadchromium_src-d4799a3bf70ecc62ab702150cae1d1e925b14938.zip
chromium_src-d4799a3bf70ecc62ab702150cae1d1e925b14938.tar.gz
chromium_src-d4799a3bf70ecc62ab702150cae1d1e925b14938.tar.bz2
FBTF: Moves code to the headers.
One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file. (Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3452030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app/sql')
-rw-r--r--app/sql/connection.cc6
-rw-r--r--app/sql/connection.h4
2 files changed, 9 insertions, 1 deletions
diff --git a/app/sql/connection.cc b/app/sql/connection.cc
index b52655a..6691252 100644
--- a/app/sql/connection.cc
+++ b/app/sql/connection.cc
@@ -49,6 +49,12 @@ bool StatementID::operator<(const StatementID& other) const {
return strcmp(str_, other.str_) < 0;
}
+ErrorDelegate::ErrorDelegate() {
+}
+
+ErrorDelegate::~ErrorDelegate() {
+}
+
Connection::StatementRef::StatementRef()
: connection_(NULL),
stmt_(NULL) {
diff --git a/app/sql/connection.h b/app/sql/connection.h
index 680cf1d..0b685cc 100644
--- a/app/sql/connection.h
+++ b/app/sql/connection.h
@@ -78,6 +78,8 @@ class Connection;
// corruption, low-level IO errors or locking violations.
class ErrorDelegate : public base::RefCounted<ErrorDelegate> {
public:
+ ErrorDelegate();
+
// |error| is an sqlite result code as seen in sqlite\preprocessed\sqlite3.h
// |connection| is db connection where the error happened and |stmt| is
// our best guess at the statement that triggered the error. Do not store
@@ -94,7 +96,7 @@ class ErrorDelegate : public base::RefCounted<ErrorDelegate> {
protected:
friend class base::RefCounted<ErrorDelegate>;
- virtual ~ErrorDelegate() {}
+ virtual ~ErrorDelegate();
};
class Connection {