Attempt 2 at:

Converts usage of SetProp/GetProp to a map. Even after making sure we
clean up props we still leak in a handful of cases that are causing
test grief. By and large our usage of properties is for inside the
application, so that a map works fine.

BUG=61528 44991
TEST=none
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/5144005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66920 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 47 insertions, 0 deletions

diff --git a/app/view_prop.h b/app/view_prop.h
new file mode 100644
index 0000000..c319460
--- /dev/null
+++ b/app/view_prop.h
@@ -0,0 +1,47 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef APP_VIEW_PROP_H_
+#define APP_VIEW_PROP_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "base/ref_counted.h"
+#include "gfx/native_widget_types.h"
+
+namespace app {
+
+// ViewProp maintains a key/value pair for a particular view. ViewProp is
+// designed as a replacement for the Win32's SetProp, but does not make use of
+// window manager memory. ViewProp shares similar semantics as SetProp, the
+// value for a particular view/key pair comes from the last ViewProp created.
+class ViewProp {
+ public:
+  // Associates data with a view/key pair. If a ViewProp has already been
+  // created for the specified pair |data| replaces the current value.
+  //
+  // ViewProp does *not* make a copy of the char*, the pointer is used for
+  // sorting.
+  ViewProp(gfx::NativeView view, const char* key, void* data);
+  ~ViewProp();
+
+  // Returns the value associated with the view/key pair, or NULL if there is
+  // none.
+  static void* GetValue(gfx::NativeView view, const char* key);
+
+  // Returns the key.
+  const char* Key() const;
+
+ private:
+  class Data;
+
+  // Stores the actual data.
+  scoped_refptr<Data> data_;
+
+  DISALLOW_COPY_AND_ASSIGN(ViewProp);
+};
+
+}  // namespace app
+
+#endif  // APP_VIEW_PROP_H_