diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-19 18:39:38 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-19 18:39:38 +0000 |
| commit | ee3724cc8eb917d0296562fd54d170273d3b8820 (patch) | |
| tree | fa10206563156f59ce8548c471e223eaf9be8d99 /app/win | |
| parent | 0f4758f7f597d5f4b608f75aba2cec316d1b62b8 (diff) | |
| download | chromium_src-ee3724cc8eb917d0296562fd54d170273d3b8820.zip chromium_src-ee3724cc8eb917d0296562fd54d170273d3b8820.tar.gz chromium_src-ee3724cc8eb917d0296562fd54d170273d3b8820.tar.bz2 | |
Converts usage of SetProp/GetProp to a map. Even after making sure we
clean up props we still leak in a handful of cases that are causing
test grief. By and large our usage of properties is for inside the
application, so that a map works fine.
BUG=61528 44991
Review URL: http://codereview.chromium.org/5075003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66784 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app/win')
| -rw-r--r-- | app/win/scoped_prop.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/app/win/scoped_prop.h b/app/win/scoped_prop.h index 14e6a6a..c309e52 100644 --- a/app/win/scoped_prop.h +++ b/app/win/scoped_prop.h @@ -18,6 +18,12 @@ namespace win { // cleanup. ScopedProp must be destroyed before the window is destroyed, else // you're going to leak a property, which could lead to failure to set a // property later on. +// +// *WARNING* +// SetProp is very fragile. SetProp makes use of a finite chunk of memory that +// is very easy to exhaust. Unless you need to share a property across process +// boundaries you should instead use ViewProp, which does not cause leaks at the +// window manager. class ScopedProp { public: // Registers the key value pair for the specified window. ScopedProp does not |