summaryrefslogtreecommitdiffstats
path: root/app
diff options
context:
space:
mode:
authorthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 12:01:29 +0000
committerthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 12:01:29 +0000
commit4de39f87c85a89046e2bbead1ddd4d6c85e1278c (patch)
tree41c862a438f14947f760c92edc9a70d0aa7215ce /app
parentfb3e985829bde90a71134801d773ad8e1407dda1 (diff)
downloadchromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.zip
chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.tar.gz
chromium_src-4de39f87c85a89046e2bbead1ddd4d6c85e1278c.tar.bz2
Standardize grit invokes
- Add two gypi files to src/build for the boilerplate added to targets and actions - Update grit_info to also support the -E flag so it can share more of the grit build commandline - switch over all but the webkit and webkit glue grd files to use the common support BUG=22247 TEST=everything still localized correctly Review URL: http://codereview.chromium.org/6705030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app')
-rw-r--r--app/app.gyp34
1 files changed, 6 insertions, 28 deletions
diff --git a/app/app.gyp b/app/app.gyp
index fc10ca0..8fd7315 100644
--- a/app/app.gyp
+++ b/app/app.gyp
@@ -4,13 +4,7 @@
{
'variables': {
- # TODO: remove this helper when we have loops in GYP
- 'apply_locales_cmd': ['python', '<(DEPTH)/build/apply_locales.py',],
'chromium_code': 1,
- 'grit_info_cmd': ['python', '../tools/grit/grit_info.py',
- '<@(grit_defines)'],
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/app',
- 'grit_cmd': ['python', '../tools/grit/grit.py'],
},
'includes': [
'app_base.gypi',
@@ -92,35 +86,19 @@
'target_name': 'app_resources',
'type': 'none',
'msvs_guid': '3FBC4235-3FBD-46DF-AEDC-BADBBA13A095',
+ 'variables': {
+ 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/app/app_resources',
+ },
'actions': [
{
'action_name': 'app_resources',
'variables': {
- 'input_path': 'resources/app_resources.grd',
+ 'grit_grd_file': 'resources/app_resources.grd',
},
- 'inputs': [
- '<!@(<(grit_info_cmd) --inputs <(input_path))',
- ],
- 'outputs': [
- '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)/app_resources\' <(input_path))',
- ],
- 'action': ['<@(grit_cmd)',
- '-i', '<(input_path)', 'build',
- '-o', '<(grit_out_dir)/app_resources',
- '<@(grit_defines)' ],
- 'message': 'Generating resources from <(input_path)',
+ 'includes': [ '../build/grit_action.gypi' ],
},
],
- 'direct_dependent_settings': {
- 'include_dirs': [
- '<(grit_out_dir)/app_resources',
- ],
- },
- 'conditions': [
- ['OS=="win"', {
- 'dependencies': ['../build/win/system.gyp:cygwin'],
- }],
- ],
+ 'includes': [ '../build/grit_target.gypi' ],
},
],
}