diff options
| author | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 22:32:16 +0000 |
|---|---|---|
| committer | tony@chromium.org <tony@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 22:32:16 +0000 |
| commit | 26d7ca2a3b70f96e0571295b0919be152598beaa (patch) | |
| tree | 80ff7fe9878f8eb305f73f7d4d096d64a124a2d8 /app | |
| parent | 85e67bff2224246e3d991acbf9492d222ab34d05 (diff) | |
| download | chromium_src-26d7ca2a3b70f96e0571295b0919be152598beaa.zip chromium_src-26d7ca2a3b70f96e0571295b0919be152598beaa.tar.gz chromium_src-26d7ca2a3b70f96e0571295b0919be152598beaa.tar.bz2 | |
Move some theme images to being serviced on the IO thread. For
Linux Release builds on my machine, all the chrome://theme/ image
requests block for 300-400ms during browser startup (it's faster
after startup). Something is blocking the UI thread so move
image requests that aren't themed off the UI thread. This is
safe to do because ResourceBundle is thread safe.
I still see chrome://theme/theme_ntp_attribution and
chrome://theme/theme_ntp_background blocking so I will look
into those next (I think with the default theme, they shouldn't
be loaded at all).
Review URL: http://codereview.chromium.org/440009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app')
| -rw-r--r-- | app/resource_bundle.cc | 2 | ||||
| -rw-r--r-- | app/resource_bundle.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/resource_bundle.cc b/app/resource_bundle.cc index 2b60c78..e3174d8 100644 --- a/app/resource_bundle.cc +++ b/app/resource_bundle.cc @@ -87,7 +87,7 @@ std::string ResourceBundle::GetDataResource(int resource_id) { } RefCountedStaticMemory* ResourceBundle::LoadDataResourceBytes( - int resource_id) { + int resource_id) const { return LoadResourceBytes(resources_data_, resource_id); } diff --git a/app/resource_bundle.h b/app/resource_bundle.h index e608ccd..5c3afb2 100644 --- a/app/resource_bundle.h +++ b/app/resource_bundle.h @@ -87,7 +87,7 @@ class ResourceBundle { // Loads the raw bytes of a data resource into |bytes|, // without doing any processing or interpretation of // the resource. Returns whether we successfully read the resource. - RefCountedStaticMemory* LoadDataResourceBytes(int resource_id); + RefCountedStaticMemory* LoadDataResourceBytes(int resource_id) const; // Return the contents of a file in a string given the resource id. // This will copy the data from the resource and return it as a string. |