Fix a ton of compiler warnings.

Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.

BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest

patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 19 insertions, 2 deletions

diff --git a/app/animation.h b/app/animation.h
index 811c038..c37adde 100644
--- a/app/animation.h
+++ b/app/animation.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 // Inspired by NSAnimation
@@ -32,6 +32,9 @@ class AnimationDelegate {
   // Called when an animation has been canceled.
   virtual void AnimationCanceled(const Animation* animation) {
   }
+
+ protected:
+  ~AnimationDelegate() {}
 };
 
 // Animation
diff --git a/app/table_model.h b/app/table_model.h
index c1e61b1..5d4377a 100644
--- a/app/table_model.h
+++ b/app/table_model.h
@@ -94,6 +94,8 @@ class TableModel {
   void ClearCollator();
 
  protected:
+  ~TableModel() {}
+
   // Returns the collator used by CompareValues.
   icu::Collator* GetCollator();
 };
diff --git a/app/table_model_observer.h b/app/table_model_observer.h
index fcd50f4..087ce28 100644
--- a/app/table_model_observer.h
+++ b/app/table_model_observer.h
@@ -20,6 +20,9 @@ class TableModelObserver {
 
   // Invoked when a range of items has been removed.
   virtual void OnItemsRemoved(int start, int length) = 0;
+
+ protected:
+  ~TableModelObserver() {}
 };
 
 #endif  // APP_TABLE_MODEL_OBSERVER_H_
diff --git a/app/tree_model.h b/app/tree_model.h
index f6d8da3..f6e2c14 100644
--- a/app/tree_model.h
+++ b/app/tree_model.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -21,6 +21,9 @@ class TreeModelNode {
  public:
   // Returns the title for the node.
   virtual const std::wstring& GetTitle() const = 0;
+
+ protected:
+  ~TreeModelNode() {}
 };
 
 // Observer for the TreeModel. Notified of significant events to the model.
@@ -45,6 +48,9 @@ class TreeModelObserver {
 
   // Notification that the contents of a node has changed.
   virtual void TreeNodeChanged(TreeModel* model, TreeModelNode* node) = 0;
+
+ protected:
+  ~TreeModelObserver() {}
 };
 
 // TreeModel ------------------------------------------------------------------
@@ -83,6 +89,9 @@ class TreeModel {
   // default icon. The index is relative to the list of icons returned from
   // GetIcons.
   virtual int GetIconIndex(TreeModelNode* node) { return -1; }
+
+ protected:
+  ~TreeModel() {}
 };
 
 #endif  // APP_TREE_TREE_MODEL_H_