diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-04 16:08:29 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-04 16:08:29 +0000 |
| commit | f298901fdf7b438d12b776407026eec114e3682b (patch) | |
| tree | b0931bef4c62eca2a6b674d7f692d25694628edf /app | |
| parent | 3bd19b38ccaedafc2dd6dd8359b7a2083e7fdae7 (diff) | |
| download | chromium_src-f298901fdf7b438d12b776407026eec114e3682b.zip chromium_src-f298901fdf7b438d12b776407026eec114e3682b.tar.gz chromium_src-f298901fdf7b438d12b776407026eec114e3682b.tar.bz2 | |
Step 1 in Implementing/Prototyping App Panels.
In this first step we
1) Create a new Browser::Type::TYPE_APP_PANEL which is observed in various places
2) Create an AppPanelBrowserFrame which is created in BrowserFrameWin when the TYPE_APP_PANEL is observed. AppPanelBrowserFrame draws itself per glen's mocks and will ultimately behave substantially different from regular browser windows.
3) Create a temporary command switch called --app-launch-as-panel which can be used until we implement actual app launching.
Note that there is still work to be done "bit-twiddling" to match glen's mocks and to implement the "inactive" look for these windows.
Steps 2 through N may include: different sizing behavior (based either on the content size or an api call), different min/maximize behavior, docking to the os taskbar, auto order & placement of app panels.
A screen capture of the current implementation is attached to the bug.
BUG=32361
Review URL: http://codereview.chromium.org/553143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38107 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'app')
| -rw-r--r-- | app/resource_bundle.cc | 4 | ||||
| -rw-r--r-- | app/resource_bundle.h | 2 | ||||
| -rw-r--r-- | app/resources/app_resources.grd | 1 | ||||
| -rwxr-xr-x | app/resources/frame_app_panel_default.png | bin | 0 -> 530 bytes |
4 files changed, 7 insertions, 0 deletions
diff --git a/app/resource_bundle.cc b/app/resource_bundle.cc index 4c13e01..9d9eb21 100644 --- a/app/resource_bundle.cc +++ b/app/resource_bundle.cc @@ -21,6 +21,10 @@ const SkColor ResourceBundle::frame_color = SkColorSetRGB(77, 139, 217); const SkColor ResourceBundle::frame_color_inactive = SkColorSetRGB(184, 209, 240); +const SkColor ResourceBundle::frame_color_app_panel = + SK_ColorWHITE; +const SkColor ResourceBundle::frame_color_app_panel_inactive = + SK_ColorWHITE; const SkColor ResourceBundle::frame_color_incognito = SkColorSetRGB(83, 106, 139); const SkColor ResourceBundle::frame_color_incognito_inactive = diff --git a/app/resource_bundle.h b/app/resource_bundle.h index 0273494..2efd932 100644 --- a/app/resource_bundle.h +++ b/app/resource_bundle.h @@ -141,6 +141,8 @@ class ResourceBundle { // ResourceBundle). static const SkColor frame_color; static const SkColor frame_color_inactive; + static const SkColor frame_color_app_panel; + static const SkColor frame_color_app_panel_inactive; static const SkColor frame_color_incognito; static const SkColor frame_color_incognito_inactive; static const SkColor toolbar_color; diff --git a/app/resources/app_resources.grd b/app/resources/app_resources.grd index cc7f7b3..c73c82ab 100644 --- a/app/resources/app_resources.grd +++ b/app/resources/app_resources.grd @@ -53,6 +53,7 @@ <!-- Frame Images --> <include name="IDR_FRAME" file="frame_default.png" type="BINDATA" /> <include name="IDR_FRAME_INACTIVE" file="frame_default_inactive.png" type="BINDATA" /> + <include name="IDR_FRAME_APP_PANEL" file="frame_app_panel_default.png" type="BINDATA" /> <!-- Frame Edge Images --> <include name="IDR_WINDOW_BOTTOM_CENTER" file="window_bottom_center.png" type="BINDATA" /> diff --git a/app/resources/frame_app_panel_default.png b/app/resources/frame_app_panel_default.png Binary files differnew file mode 100755 index 0000000..aea7e28 --- /dev/null +++ b/app/resources/frame_app_panel_default.png |
