summaryrefslogtreecommitdiffstats
path: root/apps/apps.gypi
diff options
context:
space:
mode:
authordglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-15 04:53:59 +0000
committerdglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-15 04:53:59 +0000
commita29040990b3d14ad32979a195e9f579c4ef89251 (patch)
treecabd29b0dc822d29dd9560948dc653fcc758aef1 /apps/apps.gypi
parent30620c3be07fa1c0b90a04e9c7edd92f0351f71b (diff)
downloadchromium_src-a29040990b3d14ad32979a195e9f579c4ef89251.zip
chromium_src-a29040990b3d14ad32979a195e9f579c4ef89251.tar.gz
chromium_src-a29040990b3d14ad32979a195e9f579c4ef89251.tar.bz2
Fix Secondary Window Sizing in Content Shell.
In my quest to fix fast/dom/Window/open-window-min-size.html layout test, I have travelled far and wide outside my Blink comfort zone. In this adventure, I've encountered and slayed (or I think I did) these two ogres: 1) Creating a secondary Shell window was hooked up in the wrong place. Instead of using AddNewContent, which is when a new window should be created ("do it!"), this used to be on WebContentsCreated, which is just to notify the delegate about new windows ("heads ups, new contents coming up!"). This prevented secondary Shell windows from ever knowing their sizes. I fixed this by moving the hook to the right place. 2) This triggered the need for handling the case when Blink asks for a default-sized window. In such cases, it sends 0 width/height. I repurposed a similar check used when creating new primary windows. 3) Sizing of a secondary window was a no-op from the perspective of the RenderWidgetHostView, which actually caches the size/bound locally. This resulted in secondary windows mostly always 0-sized on Linux in headless (dump-render-tree) mode. I fixed this by just delegating the sizing to RenderWidgetHostView, since it does the right thing anyway. Out of the corner of my eye, I saw a few other monsters lurking around, but my blade was running dull, and I was scared sh*tless already, so I scurried out of the field while I had my wits about. BUG=231880 TEST=fast/dom/Window/open-window-min-size.html R=brettw, jam, jochen BUG= Review URL: https://codereview.chromium.org/26983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228618 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'apps/apps.gypi')
0 files changed, 0 insertions, 0 deletions