diff options
| author | mathiash <mathiash@opera.com> | 2014-11-19 00:18:50 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-19 08:19:29 +0000 |
| commit | 72a5e46303c13d806475cd01aedfb1305fcde5d7 (patch) | |
| tree | 115076de45eb77d6d0ec3ec220d681ad977acd23 /apps/custom_launcher_page_contents.cc | |
| parent | bc4af0395bb3c948c7704a83bc989ca770d1d7f9 (diff) | |
| download | chromium_src-72a5e46303c13d806475cd01aedfb1305fcde5d7.zip chromium_src-72a5e46303c13d806475cd01aedfb1305fcde5d7.tar.gz chromium_src-72a5e46303c13d806475cd01aedfb1305fcde5d7.tar.bz2 | |
Add WebContents source to methods in WebContentsDelegate
The added parameter helps us avoid a potential timing-related security issue. The UI can be instructed to open a new tab and show a dialog roughly at the same time, and since it's handled asynchronously the dialog may end up in front of the new tab. Knowing what web contents issued the dialog would allow us to prevent that from happening.
BUG=428793
Review URL: https://codereview.chromium.org/691823002
Cr-Commit-Position: refs/heads/master@{#304781}
Diffstat (limited to 'apps/custom_launcher_page_contents.cc')
| -rw-r--r-- | apps/custom_launcher_page_contents.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/apps/custom_launcher_page_contents.cc b/apps/custom_launcher_page_contents.cc index 37e7125..150bfcf 100644 --- a/apps/custom_launcher_page_contents.cc +++ b/apps/custom_launcher_page_contents.cc @@ -87,7 +87,8 @@ bool CustomLauncherPageContents::IsPopupOrPanel( return true; } -bool CustomLauncherPageContents::ShouldSuppressDialogs() { +bool CustomLauncherPageContents::ShouldSuppressDialogs( + content::WebContents* source) { return true; } |