diff options
author | tommycli <tommycli@chromium.org> | 2014-12-09 18:09:38 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-10 02:10:09 +0000 |
commit | 59bd86cf6727dd5704bbf54f512c74dd5974d0d2 (patch) | |
tree | f9d2e4acd69f3ed5901b47a2f2ac6da3e78d504c /apps | |
parent | a09fa8bd90ed87f9e393a47c1ab3686b30fc12ce (diff) | |
download | chromium_src-59bd86cf6727dd5704bbf54f512c74dd5974d0d2.zip chromium_src-59bd86cf6727dd5704bbf54f512c74dd5974d0d2.tar.gz chromium_src-59bd86cf6727dd5704bbf54f512c74dd5974d0d2.tar.bz2 |
Plugin Power Saver: Embedder decides whether content is peripheral.
This refactor has a few goals:
1. Previously, when the user clicks on the poster image, the content origin is whitelisted. This prevents further throttling once the 'real' plugin is loaded. That's actually incorrect, and just a hack to get it working. We really just want that particular 'real' plugin to skip throttling, not whitelist the whole origin.
2. With this patch, GetPosterImage is eliminated, and ShouldThrottle and WhitelistContentOrigin are called solely on the embedder side. This supports goal #1, and also will allow us (in a subsequent patch) move parts of PluginPowerSaverHelper out of content/.
3. The embedder decides 'is_peripheral_content', and plumbs that boolean all the way down into content/. To implement the M41 PPS setting in the Settings menu, we will have to plumb 'power_saver_enabled' through to content in a similar way. content/ has no access to Settings, so the embedder has to decide and pass it down.
4. 'is_peripheral_content' is actually different from 'power_saver_enabled'. We need to pass 'is_peripheral_content' down separately, since we collect metrics on all peripheral plugins, even if the user doesn't have the setting enabled.
BUG=403800
Review URL: https://codereview.chromium.org/753553007
Cr-Commit-Position: refs/heads/master@{#307616}
Diffstat (limited to 'apps')
0 files changed, 0 insertions, 0 deletions