diff options
| author | calamity@chromium.org <calamity@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-07 19:15:40 +0000 |
|---|---|---|
| committer | calamity@chromium.org <calamity@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-07 19:15:40 +0000 |
| commit | f5bf5c08fef32c261c75ffde2707cc9e2f87bb1f (patch) | |
| tree | 6c08c640b4381a8717fe914d1c32159568f7f6d6 /apps | |
| parent | dc9e70a815624fcb05493f8c7c9472e6585f9044 (diff) | |
| download | chromium_src-f5bf5c08fef32c261c75ffde2707cc9e2f87bb1f.zip chromium_src-f5bf5c08fef32c261c75ffde2707cc9e2f87bb1f.tar.gz chromium_src-f5bf5c08fef32c261c75ffde2707cc9e2f87bb1f.tar.bz2 | |
Add default implementations for AppWindowRegistry::Observer notifications.
This CL adds default implementations for AppWindowRegistry notifications
as suggested in https://codereview.chromium.org/234673002.
This allows observers to avoid writing their own empty implementations of
unwanted notifications.
BUG=363470
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/236363011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268890 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/app_lifetime_monitor.cc | 2 | ||||
| -rw-r--r-- | apps/app_lifetime_monitor.h | 1 | ||||
| -rw-r--r-- | apps/app_window_registry.cc | 10 | ||||
| -rw-r--r-- | apps/app_window_registry.h | 6 |
4 files changed, 13 insertions, 6 deletions
diff --git a/apps/app_lifetime_monitor.cc b/apps/app_lifetime_monitor.cc index 34aa701..83a3c56 100644 --- a/apps/app_lifetime_monitor.cc +++ b/apps/app_lifetime_monitor.cc @@ -88,8 +88,6 @@ void AppLifetimeMonitor::OnAppWindowAdded(AppWindow* app_window) { NotifyAppActivated(app_window->extension_id()); } -void AppLifetimeMonitor::OnAppWindowIconChanged(AppWindow* app_window) {} - void AppLifetimeMonitor::OnAppWindowRemoved(AppWindow* app_window) { AppWindowRegistry::AppWindowList windows = AppWindowRegistry::Get(app_window->browser_context()) diff --git a/apps/app_lifetime_monitor.h b/apps/app_lifetime_monitor.h index fe63514..a9fed9c 100644 --- a/apps/app_lifetime_monitor.h +++ b/apps/app_lifetime_monitor.h @@ -63,7 +63,6 @@ class AppLifetimeMonitor : public KeyedService, // AppWindowRegistry::Observer overrides: virtual void OnAppWindowAdded(AppWindow* app_window) OVERRIDE; - virtual void OnAppWindowIconChanged(AppWindow* app_window) OVERRIDE; virtual void OnAppWindowRemoved(AppWindow* app_window) OVERRIDE; // KeyedService overrides: diff --git a/apps/app_window_registry.cc b/apps/app_window_registry.cc index 322ece9..cf4839a 100644 --- a/apps/app_window_registry.cc +++ b/apps/app_window_registry.cc @@ -45,6 +45,16 @@ std::string GetWindowKeyForRenderViewHost( namespace apps { +void AppWindowRegistry::Observer::OnAppWindowAdded(AppWindow* app_window) { +} + +void AppWindowRegistry::Observer::OnAppWindowIconChanged( + AppWindow* app_window) { +} + +void AppWindowRegistry::Observer::OnAppWindowRemoved(AppWindow* app_window) { +} + void AppWindowRegistry::Observer::OnAppWindowHidden(AppWindow* app_window) { } diff --git a/apps/app_window_registry.h b/apps/app_window_registry.h index ebde350..a055e1b 100644 --- a/apps/app_window_registry.h +++ b/apps/app_window_registry.h @@ -32,11 +32,11 @@ class AppWindowRegistry : public KeyedService { class Observer { public: // Called just after a app window was added. - virtual void OnAppWindowAdded(apps::AppWindow* app_window) = 0; + virtual void OnAppWindowAdded(apps::AppWindow* app_window); // Called when the window icon changes. - virtual void OnAppWindowIconChanged(apps::AppWindow* app_window) = 0; + virtual void OnAppWindowIconChanged(apps::AppWindow* app_window); // Called just after a app window was removed. - virtual void OnAppWindowRemoved(apps::AppWindow* app_window) = 0; + virtual void OnAppWindowRemoved(apps::AppWindow* app_window); // Called just after a app window was hidden. This is different from // window visibility as a minimize does not hide a window, but does make // it not visible. |