diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-16 20:35:18 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-16 20:35:18 +0000 |
| commit | d28775d2e8c2538a0bbea0fcb6f341a8ae861026 (patch) | |
| tree | 71012f85de71daa0f70f21dc52d84382b3f6d2c7 /ash/accessibility_delegate.h | |
| parent | e1ff4a4ae373958c2e964e57d9b07a76c20065e6 (diff) | |
| download | chromium_src-d28775d2e8c2538a0bbea0fcb6f341a8ae861026.zip chromium_src-d28775d2e8c2538a0bbea0fcb6f341a8ae861026.tar.gz chromium_src-d28775d2e8c2538a0bbea0fcb6f341a8ae861026.tar.bz2 | |
[rAC, OSX] Force better initial size for sign-in (2nd try)
This is a re-land of http://crrev.com/103853004 (r240566), which was
reverted in http://crrev.com/113913008 (r240603)
The revert was due to a test failure with the root cause that
AutofillDialogBrowserTest shows the dialog, but never runs the
NSRunLoop - which means the visual display is not fully updated. And
showing the sign-in dialog requires the main dialog's size to be non-
zero.
Fixes added:
* AutofillSignInDelegate DCHECKs for invalid sizes (better callstacks)
* AutofillDialogBrowserTest cycles run loops whenever dialog is shown
---- original description ----
Open the sign-in dialog with an initial size equal to the current
dialog. This avoids one unnecessary resize until the content is loaded
and makes the visual experience less jarring.
---- end original description ----
TBR=jochen@chromium.org
R=isherman@chromium.org
BUG=325518
Review URL: https://codereview.chromium.org/97993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241009 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/accessibility_delegate.h')
0 files changed, 0 insertions, 0 deletions