diff options
author | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-08 19:16:59 +0000 |
---|---|---|
committer | oshima@chromium.org <oshima@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-08 19:16:59 +0000 |
commit | cd9a61c70012ba2d7062f861d9ae3fe4b831f277 (patch) | |
tree | 36ec4f771194c94f290fb433e462fce602ffcb8d /ash/dip_unittest.cc | |
parent | 9bdadea89eed1e2b85b0b89df4b5a744ee933920 (diff) | |
download | chromium_src-cd9a61c70012ba2d7062f861d9ae3fe4b831f277.zip chromium_src-cd9a61c70012ba2d7062f861d9ae3fe4b831f277.tar.gz chromium_src-cd9a61c70012ba2d7062f861d9ae3fe4b831f277.tar.bz2 |
Move DIP translation from ui/aura to ui/compositor.
Layer's coordinate system is now in DIP.
Added support of dynamic density switching.
Removed ENABLE_DIP gyp/macro and added runtime flag "--ui-enable-dip"
BUG=105165, 114666
TEST=enabled monitor test. added new tests to compositor_unittests
Review URL: https://chromiumcodereview.appspot.com/10221028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135888 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/dip_unittest.cc')
-rw-r--r-- | ash/dip_unittest.cc | 65 |
1 files changed, 20 insertions, 45 deletions
diff --git a/ash/dip_unittest.cc b/ash/dip_unittest.cc index 7d57a0e..16335b3 100644 --- a/ash/dip_unittest.cc +++ b/ash/dip_unittest.cc @@ -17,80 +17,55 @@ #include "ui/aura/client/activation_client.h" #include "ui/aura/root_window.h" #include "ui/aura/window.h" +#include "ui/compositor/dip_util.h" #include "ui/compositor/layer.h" #include "ui/gfx/insets.h" #include "ui/gfx/monitor.h" #include "ui/gfx/screen.h" #include "ui/views/widget/widget.h" -#if defined(ENABLE_DIP) -#define MAYBE_Shadow FAILS_Shadow -#define MAYBE_WorkArea FAILS_WorkArea -#else -#define MAYBE_Shadow DISABLED_Shadow -#define MAYBE_WorkArea DISABLED_WorkArea -#endif - namespace ash { typedef ash::test::AshTestBase DIPTest; -// Test if the shadow works correctly under different density -TEST_F(DIPTest, MAYBE_Shadow) { - const gfx::Rect kBoundsInDIP(20, 30, 400, 300); - - scoped_ptr<aura::Window> window(new aura::Window(NULL)); - window->SetType(aura::client::WINDOW_TYPE_NORMAL); - window->Init(ui::LAYER_TEXTURED); - window->SetParent(NULL); - window->SetBounds(kBoundsInDIP); - - internal::ShadowController::TestApi api( - Shell::GetInstance()->shadow_controller()); - const internal::Shadow* shadow = api.GetShadowForWindow(window.get()); - window->Show(); - - const gfx::Rect layer_bounds_copy = shadow->layer()->bounds(); - window.reset(); - - ChangeMonitorConfig(2.0f, gfx::Rect(0, 0, 1000, 1000)); - - window.reset(new aura::Window(NULL)); - window->SetType(aura::client::WINDOW_TYPE_NORMAL); - window->Init(ui::LAYER_TEXTURED); - window->SetParent(NULL); - window->SetBounds(kBoundsInDIP); - shadow = api.GetShadowForWindow(window.get()); - window->Show(); - EXPECT_EQ("40,60 800x600", window->GetBoundsInPixel().ToString()); - EXPECT_EQ(layer_bounds_copy.Scale(2.0f).ToString(), - shadow->layer()->bounds().ToString()); -} +#if defined(OS_WIN) +// Windows/Aura doesn't have DIP support in monitor yet. +#define MAYBE_WorkArea DISABLED_WorkArea +#else +#define MAYBE_WorkArea WorkArea +#endif // Test if the WM sets correct work area under different density. TEST_F(DIPTest, MAYBE_WorkArea) { + ui::test::ScopedDIPEnablerForTest enable; ChangeMonitorConfig(1.0f, gfx::Rect(0, 0, 1000, 900)); aura::RootWindow* root = Shell::GetRootWindow(); const gfx::Monitor monitor = gfx::Screen::GetMonitorNearestWindow(root); EXPECT_EQ("0,0 1000x900", monitor.bounds().ToString()); - const gfx::Rect work_area = monitor.work_area(); - const gfx::Insets insets = monitor.bounds().InsetsFrom(work_area); - EXPECT_EQ("0,0,48,0", insets.ToString()); + gfx::Rect work_area = monitor.work_area(); + EXPECT_EQ("0,0 1000x852", work_area.ToString()); + EXPECT_EQ("0,0,48,0", monitor.bounds().InsetsFrom(work_area).ToString()); ChangeMonitorConfig(2.0f, gfx::Rect(0, 0, 2000, 1800)); const gfx::Monitor monitor_2x = gfx::Screen::GetMonitorNearestWindow(root); + // The |bounds_in_pixel()| should report bounds in pixel coordinate. EXPECT_EQ("0,0 2000x1800", monitor_2x.bounds_in_pixel().ToString()); - EXPECT_EQ("0,0 1000x900", monitor_2x.bounds().ToString()); - EXPECT_EQ(work_area.ToString(), monitor_2x.work_area().ToString()); + // Aura and views coordinates are in DIP, so they their bounds do not change. + EXPECT_EQ("0,0 1000x900", monitor_2x.bounds().ToString()); + work_area = monitor_2x.work_area(); + EXPECT_EQ("0,0 1000x852", work_area.ToString()); + EXPECT_EQ("0,0,48,0", monitor_2x.bounds().InsetsFrom(work_area).ToString()); + // Sanity check if the workarea's inset hight is same as + // the launcher's height. Launcher* launcher = Shell::GetInstance()->launcher(); EXPECT_EQ( - monitor_2x.bounds().InsetsFrom(work_area).height() * 2, + monitor_2x.bounds().InsetsFrom(work_area).height(), launcher->widget()->GetNativeView()->layer()->bounds().height()); } |