diff options
author | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-19 16:07:39 +0000 |
---|---|---|
committer | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-19 16:07:39 +0000 |
commit | 551ebc53dad82cdd8a4660ae62d4651e7d364532 (patch) | |
tree | 4ca54e925aa53a846bf13907ce901b96b524dd45 /ash/focus_cycler_unittest.cc | |
parent | 2ee4c5648cface157ffb0963d5ac36cadc36b61e (diff) | |
download | chromium_src-551ebc53dad82cdd8a4660ae62d4651e7d364532.zip chromium_src-551ebc53dad82cdd8a4660ae62d4651e7d364532.tar.gz chromium_src-551ebc53dad82cdd8a4660ae62d4651e7d364532.tar.bz2 |
Disable CycleFocus* tests because of use-after-free errors in them.
BUG=TODO(glider)
TBR=sky
Review URL: https://codereview.chromium.org/11233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162999 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/focus_cycler_unittest.cc')
-rw-r--r-- | ash/focus_cycler_unittest.cc | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/ash/focus_cycler_unittest.cc b/ash/focus_cycler_unittest.cc index f694f45..a920903 100644 --- a/ash/focus_cycler_unittest.cc +++ b/ash/focus_cycler_unittest.cc @@ -44,7 +44,10 @@ SystemTray* CreateSystemTray() { typedef AshTestBase FocusCyclerTest; -TEST_F(FocusCyclerTest, CycleFocusBrowserOnly) { +// FocusCyclerTest and FocusCyclerLauncherTest tests are disabled due to +// use-after-free bugs in them detectable by both AddressSanitizer and Valgrind. +// TODO(glider): file a bug. +TEST_F(FocusCyclerTest, DISABLED_CycleFocusBrowserOnly) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Create a single test window. @@ -57,7 +60,7 @@ TEST_F(FocusCyclerTest, CycleFocusBrowserOnly) { EXPECT_TRUE(wm::IsActiveWindow(window0.get())); } -TEST_F(FocusCyclerTest, CycleFocusForward) { +TEST_F(FocusCyclerTest, DISABLED_CycleFocusForward) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Add the Status area @@ -92,7 +95,7 @@ TEST_F(FocusCyclerTest, CycleFocusForward) { EXPECT_TRUE(wm::IsActiveWindow(window0.get())); } -TEST_F(FocusCyclerTest, CycleFocusBackward) { +TEST_F(FocusCyclerTest, DISABLED_CycleFocusBackward) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Add the Status area @@ -127,7 +130,7 @@ TEST_F(FocusCyclerTest, CycleFocusBackward) { EXPECT_TRUE(wm::IsActiveWindow(window0.get())); } -TEST_F(FocusCyclerTest, CycleFocusForwardBackward) { +TEST_F(FocusCyclerTest, DISABLED_CycleFocusForwardBackward) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Add the Status area @@ -174,7 +177,7 @@ TEST_F(FocusCyclerTest, CycleFocusForwardBackward) { EXPECT_TRUE(wm::IsActiveWindow(window0.get())); } -TEST_F(FocusCyclerTest, CycleFocusNoBrowser) { +TEST_F(FocusCyclerTest, DISABLED_CycleFocusNoBrowser) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Add the Status area @@ -244,7 +247,7 @@ class FocusCyclerLauncherTest : public AshTestBase { DISALLOW_COPY_AND_ASSIGN(FocusCyclerLauncherTest); }; -TEST_F(FocusCyclerLauncherTest, CycleFocusForwardInvisible) { +TEST_F(FocusCyclerLauncherTest, DISABLED_CycleFocusForwardInvisible) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Add the Status area @@ -275,7 +278,7 @@ TEST_F(FocusCyclerLauncherTest, CycleFocusForwardInvisible) { EXPECT_TRUE(wm::IsActiveWindow(window0.get())); } -TEST_F(FocusCyclerLauncherTest, CycleFocusBackwardInvisible) { +TEST_F(FocusCyclerLauncherTest, DISABLED_CycleFocusBackwardInvisible) { scoped_ptr<FocusCycler> focus_cycler(new FocusCycler()); // Add the Status area |