diff options
author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-20 17:13:08 +0000 |
---|---|---|
committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-20 17:13:08 +0000 |
commit | 2dca2dc97fd303df0c6a1fb11828472ef1c00428 (patch) | |
tree | 0c167969ade022b0a6219255feedd0d198bcdede /ash/magnifier | |
parent | 06ad578f489b38c5f4fc9bc08864f3dc0b3dea4e (diff) | |
download | chromium_src-2dca2dc97fd303df0c6a1fb11828472ef1c00428.zip chromium_src-2dca2dc97fd303df0c6a1fb11828472ef1c00428.tar.gz chromium_src-2dca2dc97fd303df0c6a1fb11828472ef1c00428.tar.bz2 |
ui: Add default implementations for EventHandler interface.
This allows getting rid of a whole bunch of noop implementations, and makes
it easier to add new event types to be dispatched through the EventDispatcher
to EventHandlers.
BUG=159632
Review URL: https://codereview.chromium.org/11348145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168817 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/magnifier')
-rw-r--r-- | ash/magnifier/magnification_controller.cc | 17 | ||||
-rw-r--r-- | ash/magnifier/partial_magnification_controller.cc | 20 | ||||
-rw-r--r-- | ash/magnifier/partial_magnification_controller.h | 4 |
3 files changed, 0 insertions, 41 deletions
diff --git a/ash/magnifier/magnification_controller.cc b/ash/magnifier/magnification_controller.cc index 63b0307..4427a11 100644 --- a/ash/magnifier/magnification_controller.cc +++ b/ash/magnifier/magnification_controller.cc @@ -117,11 +117,8 @@ class MagnificationControllerImpl : virtual public MagnificationController, void ValidateScale(float* scale); // ui::EventHandler overrides: - virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE; virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE; virtual ui::EventResult OnScrollEvent(ui::ScrollEvent* event) OVERRIDE; - virtual ui::EventResult OnTouchEvent(ui::TouchEvent* event) OVERRIDE; - virtual ui::EventResult OnGestureEvent(ui::GestureEvent* event) OVERRIDE; aura::RootWindow* root_window_; @@ -450,10 +447,6 @@ bool MagnificationControllerImpl::IsEnabled() const { //////////////////////////////////////////////////////////////////////////////// // MagnificationControllerImpl: aura::EventFilter implementation -ui::EventResult MagnificationControllerImpl::OnKeyEvent(ui::KeyEvent* event) { - return ui::ER_UNHANDLED; -} - ui::EventResult MagnificationControllerImpl::OnMouseEvent( ui::MouseEvent* event) { if (IsMagnified() && event->type() == ui::ET_MOUSE_MOVED) { @@ -492,16 +485,6 @@ ui::EventResult MagnificationControllerImpl::OnScrollEvent( return ui::ER_UNHANDLED; } -ui::EventResult MagnificationControllerImpl::OnTouchEvent( - ui::TouchEvent* event) { - return ui::ER_UNHANDLED; -} - -ui::EventResult MagnificationControllerImpl::OnGestureEvent( - ui::GestureEvent* event) { - return ui::ER_UNHANDLED; -} - //////////////////////////////////////////////////////////////////////////////// // MagnificationController: diff --git a/ash/magnifier/partial_magnification_controller.cc b/ash/magnifier/partial_magnification_controller.cc index 7b682a7..cdabbf2 100644 --- a/ash/magnifier/partial_magnification_controller.cc +++ b/ash/magnifier/partial_magnification_controller.cc @@ -76,11 +76,6 @@ void PartialMagnificationController::SetEnabled(bool enabled) { //////////////////////////////////////////////////////////////////////////////// // PartialMagnificationController: ui::EventHandler implementation -ui::EventResult PartialMagnificationController::OnKeyEvent( - ui::KeyEvent* event) { - return ui::ER_UNHANDLED; -} - ui::EventResult PartialMagnificationController::OnMouseEvent( ui::MouseEvent* event) { if (IsPartialMagnified() && event->type() == ui::ET_MOUSE_MOVED) { @@ -100,21 +95,6 @@ ui::EventResult PartialMagnificationController::OnMouseEvent( return ui::ER_UNHANDLED; } -ui::EventResult PartialMagnificationController::OnScrollEvent( - ui::ScrollEvent* event) { - return ui::ER_UNHANDLED; -} - -ui::EventResult PartialMagnificationController::OnTouchEvent( - ui::TouchEvent* event) { - return ui::ER_UNHANDLED; -} - -ui::EventResult PartialMagnificationController::OnGestureEvent( - ui::GestureEvent* event) { - return ui::ER_UNHANDLED; -} - //////////////////////////////////////////////////////////////////////////////// // PartialMagnificationController: aura::WindowObserver implementation diff --git a/ash/magnifier/partial_magnification_controller.h b/ash/magnifier/partial_magnification_controller.h index 7908d97..24e57d3 100644 --- a/ash/magnifier/partial_magnification_controller.h +++ b/ash/magnifier/partial_magnification_controller.h @@ -67,11 +67,7 @@ class PartialMagnificationController void RemoveZoomWidgetObservers(); // ui::EventHandler overrides: - virtual ui::EventResult OnKeyEvent(ui::KeyEvent* event) OVERRIDE; virtual ui::EventResult OnMouseEvent(ui::MouseEvent* event) OVERRIDE; - virtual ui::EventResult OnScrollEvent(ui::ScrollEvent* event) OVERRIDE; - virtual ui::EventResult OnTouchEvent(ui::TouchEvent* event) OVERRIDE; - virtual ui::EventResult OnGestureEvent(ui::GestureEvent* event) OVERRIDE; // Overridden from WindowObserver: virtual void OnWindowDestroying(aura::Window* window) OVERRIDE; |