diff options
| author | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-05 22:15:35 +0000 |
|---|---|---|
| committer | wittman@chromium.org <wittman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-05 22:15:35 +0000 |
| commit | 84685520948dcbf750736faa3e2bcc9dc430e861 (patch) | |
| tree | 4bfc4086238f2f94355a689c142c5543b9664a09 /ash/magnifier | |
| parent | f84973412773063d475d1b9f91540e6f6fa6e4da (diff) | |
| download | chromium_src-84685520948dcbf750736faa3e2bcc9dc430e861.zip chromium_src-84685520948dcbf750736faa3e2bcc9dc430e861.tar.gz chromium_src-84685520948dcbf750736faa3e2bcc9dc430e861.tar.bz2 | |
Add synchronous Widget closing event
Adds a WidgetObserver event that is guaranteed to be invoked synchronously
when a Widget is requested to close. Rename the existing event, which
is invoked at Widget destruction time, typically via a task on the event
loop, to OnWidgetDestroying.
The new event will be used in Views-specific WebContentsModalDialogManager
functionality to get close events for Widgets, so that we don't risk
adverse interleaving of Widget close events with other relevant events
(e.g. IPC). This will allow us to avoids test flakiness observed
in https://codereview.chromium.org/12045037 due to event races in
PrintPreviewTest.PrintCommands
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/12089061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180796 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/magnifier')
| -rw-r--r-- | ash/magnifier/partial_magnification_controller.cc | 2 | ||||
| -rw-r--r-- | ash/magnifier/partial_magnification_controller.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/ash/magnifier/partial_magnification_controller.cc b/ash/magnifier/partial_magnification_controller.cc index 2a4ab84..3020511 100644 --- a/ash/magnifier/partial_magnification_controller.cc +++ b/ash/magnifier/partial_magnification_controller.cc @@ -104,7 +104,7 @@ void PartialMagnificationController::OnWindowDestroying( SwitchTargetRootWindow(new_root_window); } -void PartialMagnificationController::OnWidgetClosing( +void PartialMagnificationController::OnWidgetDestroying( views::Widget* widget) { DCHECK_EQ(widget, zoom_widget_); RemoveZoomWidgetObservers(); diff --git a/ash/magnifier/partial_magnification_controller.h b/ash/magnifier/partial_magnification_controller.h index dc95360c..1b8c8fb 100644 --- a/ash/magnifier/partial_magnification_controller.h +++ b/ash/magnifier/partial_magnification_controller.h @@ -73,7 +73,7 @@ class PartialMagnificationController virtual void OnWindowDestroying(aura::Window* window) OVERRIDE; // Overridden from WidgetObserver: - virtual void OnWidgetClosing(views::Widget* widget) OVERRIDE; + virtual void OnWidgetDestroying(views::Widget* widget) OVERRIDE; // True if the magnified window is in motion of zooming or un-zooming effect. // Otherwise, false. |