diff options
author | dcheng <dcheng@chromium.org> | 2014-10-27 16:57:05 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-27 23:58:04 +0000 |
commit | 1f4538e02ae35659abf7f9468639a1045924af50 (patch) | |
tree | 1e076638bbebe64689099c5ea5bd82bfa9c6b9aa /ash/rotator/screen_rotation.h | |
parent | e19d49ab07f57c16eb6685e7394ac4902e53382c (diff) | |
download | chromium_src-1f4538e02ae35659abf7f9468639a1045924af50.zip chromium_src-1f4538e02ae35659abf7f9468639a1045924af50.tar.gz chromium_src-1f4538e02ae35659abf7f9468639a1045924af50.tar.bz2 |
Standardize usage of virtual/override/final specifiers.
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=derat@chromium.org
Review URL: https://codereview.chromium.org/680153002
Cr-Commit-Position: refs/heads/master@{#301490}
Diffstat (limited to 'ash/rotator/screen_rotation.h')
-rw-r--r-- | ash/rotator/screen_rotation.h | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/ash/rotator/screen_rotation.h b/ash/rotator/screen_rotation.h index 500f6c3..360e53b 100644 --- a/ash/rotator/screen_rotation.h +++ b/ash/rotator/screen_rotation.h @@ -31,7 +31,7 @@ class ASH_EXPORT ScreenRotation : public ui::LayerAnimationElement { // |degrees| are clockwise. |layer| is the target of the animation. Does not // take ownership of |layer|. ScreenRotation(int degrees, ui::Layer* layer); - virtual ~ScreenRotation(); + ~ScreenRotation() override; private: // Generates the intermediate transformation matrices used during the @@ -39,11 +39,10 @@ class ASH_EXPORT ScreenRotation : public ui::LayerAnimationElement { void InitTransform(ui::Layer* layer); // Implementation of ui::LayerAnimationDelegate - virtual void OnStart(ui::LayerAnimationDelegate* delegate) override; - virtual bool OnProgress(double t, - ui::LayerAnimationDelegate* delegate) override; - virtual void OnGetTarget(TargetValue* target) const override; - virtual void OnAbort(ui::LayerAnimationDelegate* delegate) override; + void OnStart(ui::LayerAnimationDelegate* delegate) override; + bool OnProgress(double t, ui::LayerAnimationDelegate* delegate) override; + void OnGetTarget(TargetValue* target) const override; + void OnAbort(ui::LayerAnimationDelegate* delegate) override; scoped_ptr<ui::InterpolatedTransform> interpolated_transform_; |