diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-21 05:34:40 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-21 05:34:40 +0000 |
| commit | 27f6af6d0acc3fb17eb46b9b6e237d6468467d8a (patch) | |
| tree | ded1351abc471445d06ba49f72bffd59dc52c3e9 /ash/shell.h | |
| parent | f0e524cb492503bd20513e11bd379df98c97bb3a (diff) | |
| download | chromium_src-27f6af6d0acc3fb17eb46b9b6e237d6468467d8a.zip chromium_src-27f6af6d0acc3fb17eb46b9b6e237d6468467d8a.tar.gz chromium_src-27f6af6d0acc3fb17eb46b9b6e237d6468467d8a.tar.bz2 | |
Makes the launcher auto-hide for maximized windows. This turned out to
be a bit icky for a handful of reasons. In particular it means the
work area changes after going maximized so that you can't assume
maximized windows get the work area bounds. This makes for some
ordering dependencies. I've had to expose the bounds for maximized
windows (and non-maximized windows).
The code feels a bit messy in a number of places right now. In
particular there a handful of places (in testing code) mucking with
work area insets. We don't want that as it generally doesn't do the
right thing anymore.
BUG=116070 118671
TEST=covered by tests, but all see bugs.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9764008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127904 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/shell.h')
| -rw-r--r-- | ash/shell.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ash/shell.h b/ash/shell.h index 411e6b2..91ee69f 100644 --- a/ash/shell.h +++ b/ash/shell.h @@ -151,6 +151,8 @@ class ASH_EXPORT Shell { // Sets the work area insets of the monitor that contains |window|, // this notifies observers too. + // TODO(sky): this no longer really replicates what happens and is unreliable. + // Remove this. void SetMonitorWorkAreaInsets(aura::Window* window, const gfx::Insets& insets); |