summaryrefslogtreecommitdiffstats
path: root/ash/shell.h
diff options
context:
space:
mode:
authormmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-25 13:35:15 +0000
committermmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-25 13:35:15 +0000
commit165de394ecebc09dde064249137c775baf20dc4d (patch)
treed2d7719041e1a2fce383208c51d15a282db8fca1 /ash/shell.h
parent7dca93ea629f94354224f82af1524f952a60bf14 (diff)
downloadchromium_src-165de394ecebc09dde064249137c775baf20dc4d.zip
chromium_src-165de394ecebc09dde064249137c775baf20dc4d.tar.gz
chromium_src-165de394ecebc09dde064249137c775baf20dc4d.tar.bz2
Revert 272740 "Refactor and move ash independent accelerator han..."
Causing compile failures on Windows. Possible comatability issue with https://codereview.chromium.org/298703007 Sample errors: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\ui\wm\core\wm_unittests.nested_accelerator_controller_unittest.obj.rsp /c ..\..\ui\wm\core\nested_accelerator_controller_unittest.cc /Foobj\ui\wm\core\wm_unittests.nested_accelerator_controller_unittest.obj /Fdobj\ui\wm\wm_unittests.cc.pdb c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(83) : error C2039: 'host' : is not a member of 'aura::Window' c:\b\build\slave\win\build\src\ui\aura\window.h(62) : see declaration of 'aura::Window' c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(83) : error C2227: left of '->PostNativeEvent' must point to class/struct/union/generic type c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(85) : error C2039: 'host' : is not a member of 'aura::Window' c:\b\build\slave\win\build\src\ui\aura\window.h(62) : see declaration of 'aura::Window' c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(85) : error C2227: left of '->PostNativeEvent' must point to class/struct/union/generic type ninja: build stopped: subcommand failed. > Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core > > I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them. > > BUG=None > > Review URL: https://codereview.chromium.org/298703007 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/300093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272759 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/shell.h')
-rw-r--r--ash/shell.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/ash/shell.h b/ash/shell.h
index 354d653..e889131 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -64,7 +64,6 @@ class TooltipController;
namespace wm {
class CompoundEventFilter;
class InputMethodEventFilter;
-class NestedAcceleratorController;
class ShadowController;
class VisibilityController;
class UserActivityDetector;
@@ -107,6 +106,7 @@ class MaximizeModeWindowManager;
class MediaDelegate;
class MouseCursorEventFilter;
class MruWindowTracker;
+class NestedDispatcherController;
class NewWindowDelegate;
class OverlayEventFilter;
class PartialMagnificationController;
@@ -623,7 +623,7 @@ class ASH_EXPORT Shell : public SystemModalContainerEventFilterDelegate,
std::vector<WindowAndBoundsPair> to_restore_;
scoped_ptr<UserMetricsRecorder> user_metrics_recorder_;
- scoped_ptr< ::wm::NestedAcceleratorController> nested_accelerator_controller_;
+ scoped_ptr<NestedDispatcherController> nested_dispatcher_controller_;
scoped_ptr<AcceleratorController> accelerator_controller_;
scoped_ptr<ShellDelegate> delegate_;
scoped_ptr<SystemTrayDelegate> system_tray_delegate_;