diff options
| author | bshe@chromium.org <bshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 17:29:34 +0000 |
|---|---|---|
| committer | bshe@chromium.org <bshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 17:29:34 +0000 |
| commit | 20551f90725e4f58ed0ef19b43329c3b0f2dfc2a (patch) | |
| tree | bfd6a9424dfbbc44007fac68e794b8af9e6d9815 /ash/shell_factory.h | |
| parent | a75af9f69962505ca6a4d25e30b2120dc3dfd035 (diff) | |
| download | chromium_src-20551f90725e4f58ed0ef19b43329c3b0f2dfc2a.zip chromium_src-20551f90725e4f58ed0ef19b43329c3b0f2dfc2a.tar.gz chromium_src-20551f90725e4f58ed0ef19b43329c3b0f2dfc2a.tar.bz2 | |
Fix wallpaper fade animation flashing problem.
This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.
To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.
BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.
Review URL: http://codereview.chromium.org/10146016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133468 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash/shell_factory.h')
| -rw-r--r-- | ash/shell_factory.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ash/shell_factory.h b/ash/shell_factory.h index 1e57953..03b8170 100644 --- a/ash/shell_factory.h +++ b/ash/shell_factory.h @@ -21,8 +21,7 @@ class Widget; namespace ash { namespace internal { -views::Widget* CreateDesktopBackground(const SkBitmap& wallpaper, - ImageLayout layout); +void CreateDesktopBackground(const SkBitmap& wallpaper, ImageLayout layout); ASH_EXPORT views::Widget* CreateStatusArea(views::View* contents); } // namespace internal |