Allows OnAppTerminating at AshTestBase::TearDown().

Adding OnAppTerminating causes some failures. This CL also includes
the fixes for them.

OverlayEventFilterTest.CancelAtActivating:
- OverlayEventFilter::Cancel() is called, but that does not cleanup
  |delegate_|, therefore further OnAppTerminating() invokes Cancel()
  to already canceled delegate_.

PartialScreenshotViewTest.DontStartOverOverlay:
- delegate should be deactivated before it's removed.

RootWindowControllerTest.DontDeleteWindowsNotOwnedByParent:
- this test case explicitly invokes CloseAllChildWindows(), therefore
  it cleans up all of the containers.
- SessionStateAnimatorImpl assumed containers still exist when
  OnAppTerminating() is invoked.

WindowManagerTest.TestCursorClientObserver:
- observer_a is added to cursor_manager, but not destructed without
  calling RemoveObserver().

BUG=None
R=oshima@chromium.org
TEST=ash_unittests

Review URL: https://codereview.chromium.org/809603008

Cr-Commit-Position: refs/heads/master@{#308772}

1 files changed, 2 insertions, 0 deletions

diff --git a/ash/wm/window_manager_unittest.cc b/ash/wm/window_manager_unittest.cc
index 6a51a0f..61aaaf2 100644
--- a/ash/wm/window_manager_unittest.cc
+++ b/ash/wm/window_manager_unittest.cc
@@ -832,6 +832,8 @@ TEST_F(WindowManagerTest, TestCursorClientObserver) {
   EXPECT_TRUE(observer_a.did_visibility_change());
   EXPECT_FALSE(observer_b.did_visibility_change());
   EXPECT_TRUE(observer_a.is_cursor_visible());
+
+  cursor_manager->RemoveObserver(&observer_a);
 }
 #endif  // defined(OS_CHROMEOS)