diff options
| author | msw@google.com <msw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-07 23:08:16 +0000 |
|---|---|---|
| committer | msw@google.com <msw@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-07 23:08:16 +0000 |
| commit | 7f39bb69692953a1085bd2ac7eb8eb53ecf5f46a (patch) | |
| tree | 48d8389d7940e85e3ed952c7a6d4b2a5d1345d97 /ash | |
| parent | 01b054ac8a880dfc1f84229d902cb86535e3e838 (diff) | |
| download | chromium_src-7f39bb69692953a1085bd2ac7eb8eb53ecf5f46a.zip chromium_src-7f39bb69692953a1085bd2ac7eb8eb53ecf5f46a.tar.gz chromium_src-7f39bb69692953a1085bd2ac7eb8eb53ecf5f46a.tar.bz2 | |
Implement rough new dialog style.
Add/update and use NativeTheme dialog colors for Win/Aura.
Use Label[Button] and Bubble[Border|Background] in DialogFrameView.
Add DialogFrameView::content_margins_ similar to BubbleFrameView.
Increase widget example size, add DialogExample with title.
Tweak dialog example InitParams (nix frame, make transparent).
Make the buttons in the widget example focusable.
Make LabelButton::GetPreferredSize public.
Refactor BubbleFrameView::GetBoundsForClientView.
Roughly matches the specification at:
https://docs.google.com/a/google.com/file/d/0B6x6iYCtKinEVjFvOWNfRlJCLU0/edit
See the screenshot on the bug at:
https://code.google.com/p/chromium/issues/detail?id=166075#c5
TODO(followup): Investigate a minor LabelButton drag/hot issue.
TODO(followup): Add/use new close (x) button resources.
TODO(followup): Generalize BubbleBorder to a custom frame border?
BUG=166075
TEST=[Views examples] dialogs look closer to mocks with --enable-new-dialog-style (actual Chrome dialogs need more work).
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11756005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175411 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ash')
| -rw-r--r-- | ash/shell.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ash/shell.cc b/ash/shell.cc index 48f4350..29029cc 100644 --- a/ash/shell.cc +++ b/ash/shell.cc @@ -647,7 +647,7 @@ views::NonClientFrameView* Shell::CreateDefaultNonClientFrameView( views::Widget* widget) { if (CommandLine::ForCurrentProcess()->HasSwitch( ::switches::kEnableNewDialogStyle)) { - return new views::DialogFrameView; + return new views::DialogFrameView(string16()); } // Use translucent-style window frames for dialogs. CustomFrameViewAsh* frame_view = new CustomFrameViewAsh; |