ash: Rename LauncherModelObserver to ShelfModelObserver.

- move launcher_model_observer.h from launcher/ to shelf/
- rename to shelf_model_observer.h

BUG=248353
TEST=None, no functional changes
R=harrym@chromium.org,jamescook@chromium.org

Review URL: https://codereview.chromium.org/68243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234686 0039d316-1c4b-4281-b951-d872f2087c98

10 files changed, 102 insertions, 107 deletions

diff --git a/ash/ash.gyp b/ash/ash.gyp
index af36f40..e19e25f 100644
--- a/ash/ash.gyp
+++ b/ash/ash.gyp
@@ -166,7 +166,6 @@
         'launcher/launcher_item_delegate.h',
         'launcher/launcher_model.cc',
         'launcher/launcher_model.h',
-        'launcher/launcher_model_observer.h',
         'launcher/launcher_types.cc',
         'launcher/launcher_types.h',
         'magnifier/magnification_controller.cc',
@@ -215,6 +214,7 @@
         'shelf/shelf_layout_manager.cc',
         'shelf/shelf_layout_manager.h',
         'shelf/shelf_layout_manager_observer.h',
+        'shelf/shelf_model_observer.h',
         'shelf/shelf_model_util.cc',
         'shelf/shelf_model_util.h',
         'shelf/shelf_navigator.cc',
diff --git a/ash/launcher/launcher_item_delegate_manager.cc b/ash/launcher/launcher_item_delegate_manager.cc
index e401b76..ecc821c 100644
--- a/ash/launcher/launcher_item_delegate_manager.cc
+++ b/ash/launcher/launcher_item_delegate_manager.cc
@@ -44,24 +44,23 @@ LauncherItemDelegate* LauncherItemDelegateManager::GetLauncherItemDelegate(
   return NULL;
 }
 
-void LauncherItemDelegateManager::LauncherItemAdded(int index) {
+void LauncherItemDelegateManager::ShelfItemAdded(int index) {
 }
 
-void LauncherItemDelegateManager::LauncherItemRemoved(int index,
-                                                      ash::LauncherID id) {
+void LauncherItemDelegateManager::ShelfItemRemoved(int index, LauncherID id) {
   RemoveLauncherItemDelegate(id);
 }
 
-void LauncherItemDelegateManager::LauncherItemMoved(int start_index,
-                                                    int target_index) {
+void LauncherItemDelegateManager::ShelfItemMoved(int start_index,
+                                                 int target_index) {
 }
 
-void LauncherItemDelegateManager::LauncherItemChanged(
+void LauncherItemDelegateManager::ShelfItemChanged(
     int index,
     const LauncherItem& old_item) {
 }
 
-void LauncherItemDelegateManager::LauncherStatusChanged() {
+void LauncherItemDelegateManager::ShelfStatusChanged() {
 }
 
 void LauncherItemDelegateManager::RemoveLauncherItemDelegate(
diff --git a/ash/launcher/launcher_item_delegate_manager.h b/ash/launcher/launcher_item_delegate_manager.h
index 168a094..a04e1e0 100644
--- a/ash/launcher/launcher_item_delegate_manager.h
+++ b/ash/launcher/launcher_item_delegate_manager.h
@@ -8,8 +8,8 @@
 #include <map>
 
 #include "ash/ash_export.h"
-#include "ash/launcher/launcher_model_observer.h"
 #include "ash/launcher/launcher_types.h"
+#include "ash/shelf/shelf_model_observer.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 
@@ -26,8 +26,7 @@ class LauncherItemDelegateManagerTestAPI;
 // rather it is expected that someone else invokes SetLauncherItemDelegate
 // appropriately. On the other hand, LauncherItemDelegateManager destroys
 // LauncherItemDelegates when the corresponding item from the model is removed.
-class ASH_EXPORT LauncherItemDelegateManager
-    : public ash::LauncherModelObserver {
+class ASH_EXPORT LauncherItemDelegateManager : public ShelfModelObserver {
  public:
   explicit LauncherItemDelegateManager(ash::LauncherModel* model);
   virtual ~LauncherItemDelegateManager();
@@ -40,14 +39,13 @@ class ASH_EXPORT LauncherItemDelegateManager
   // Returns LauncherItemDelegate for |item_type|. Always returns non-NULL.
   LauncherItemDelegate* GetLauncherItemDelegate(ash::LauncherID id);
 
-  // ash::LauncherModelObserver overrides:
-  virtual void LauncherItemAdded(int model_index) OVERRIDE;
-  virtual void LauncherItemRemoved(int index, ash::LauncherID id) OVERRIDE;
-  virtual void LauncherItemMoved(int start_index, int targetindex) OVERRIDE;
-  virtual void LauncherItemChanged(
-      int index,
-      const ash::LauncherItem& old_item) OVERRIDE;
-  virtual void LauncherStatusChanged() OVERRIDE;
+  // ShelfModelObserver overrides:
+  virtual void ShelfItemAdded(int model_index) OVERRIDE;
+  virtual void ShelfItemRemoved(int index, ash::LauncherID id) OVERRIDE;
+  virtual void ShelfItemMoved(int start_index, int targetindex) OVERRIDE;
+  virtual void ShelfItemChanged(int index,
+                                const LauncherItem& old_item) OVERRIDE;
+  virtual void ShelfStatusChanged() OVERRIDE;
 
  private:
   friend class ash::test::LauncherItemDelegateManagerTestAPI;
diff --git a/ash/launcher/launcher_model.cc b/ash/launcher/launcher_model.cc
index 10e39e8..a8c206393 100644
--- a/ash/launcher/launcher_model.cc
+++ b/ash/launcher/launcher_model.cc
@@ -7,7 +7,7 @@
 #include <algorithm>
 
 #include "ash/ash_switches.h"
-#include "ash/launcher/launcher_model_observer.h"
+#include "ash/shelf/shelf_model_observer.h"
 
 namespace ash {
 
@@ -74,8 +74,7 @@ int LauncherModel::AddAt(int index, const LauncherItem& item) {
   index = ValidateInsertionIndex(item.type, index);
   items_.insert(items_.begin() + index, item);
   items_[index].id = next_id_++;
-  FOR_EACH_OBSERVER(LauncherModelObserver, observers_,
-                    LauncherItemAdded(index));
+  FOR_EACH_OBSERVER(ShelfModelObserver, observers_, ShelfItemAdded(index));
   return index;
 }
 
@@ -86,8 +85,8 @@ void LauncherModel::RemoveItemAt(int index) {
          items_[index].type != TYPE_BROWSER_SHORTCUT);
   LauncherID id = items_[index].id;
   items_.erase(items_.begin() + index);
-  FOR_EACH_OBSERVER(LauncherModelObserver, observers_,
-                    LauncherItemRemoved(index, id));
+  FOR_EACH_OBSERVER(ShelfModelObserver, observers_,
+                    ShelfItemRemoved(index, id));
 }
 
 void LauncherModel::Move(int index, int target_index) {
@@ -97,8 +96,8 @@ void LauncherModel::Move(int index, int target_index) {
   LauncherItem item(items_[index]);
   items_.erase(items_.begin() + index);
   items_.insert(items_.begin() + target_index, item);
-  FOR_EACH_OBSERVER(LauncherModelObserver, observers_,
-                    LauncherItemMoved(index, target_index));
+  FOR_EACH_OBSERVER(ShelfModelObserver, observers_,
+                    ShelfItemMoved(index, target_index));
 }
 
 void LauncherModel::Set(int index, const LauncherItem& item) {
@@ -109,8 +108,8 @@ void LauncherModel::Set(int index, const LauncherItem& item) {
   LauncherItem old_item(items_[index]);
   items_[index] = item;
   items_[index].id = old_item.id;
-  FOR_EACH_OBSERVER(LauncherModelObserver, observers_,
-                    LauncherItemChanged(index, old_item));
+  FOR_EACH_OBSERVER(ShelfModelObserver, observers_,
+                    ShelfItemChanged(index, old_item));
 
   // If the type changes confirm that the item is still in the right order.
   if (new_index != index) {
@@ -153,15 +152,14 @@ void LauncherModel::SetStatus(Status status) {
     return;
 
   status_ = status;
-  FOR_EACH_OBSERVER(LauncherModelObserver, observers_,
-                    LauncherStatusChanged());
+  FOR_EACH_OBSERVER(ShelfModelObserver, observers_, ShelfStatusChanged());
 }
 
-void LauncherModel::AddObserver(LauncherModelObserver* observer) {
+void LauncherModel::AddObserver(ShelfModelObserver* observer) {
   observers_.AddObserver(observer);
 }
 
-void LauncherModel::RemoveObserver(LauncherModelObserver* observer) {
+void LauncherModel::RemoveObserver(ShelfModelObserver* observer) {
   observers_.RemoveObserver(observer);
 }
 
diff --git a/ash/launcher/launcher_model.h b/ash/launcher/launcher_model.h
index 9d42844..2845fb0 100644
--- a/ash/launcher/launcher_model.h
+++ b/ash/launcher/launcher_model.h
@@ -12,7 +12,7 @@
 
 namespace ash {
 
-class LauncherModelObserver;
+class ShelfModelObserver;
 
 // Model used by ShelfView.
 class ASH_EXPORT LauncherModel {
@@ -67,8 +67,8 @@ class ASH_EXPORT LauncherModel {
   void SetStatus(Status status);
   Status status() const { return status_; }
 
-  void AddObserver(LauncherModelObserver* observer);
-  void RemoveObserver(LauncherModelObserver* observer);
+  void AddObserver(ShelfModelObserver* observer);
+  void RemoveObserver(ShelfModelObserver* observer);
 
  private:
   // Makes sure |index| is in line with the type-based order of items. If that
@@ -81,7 +81,7 @@ class ASH_EXPORT LauncherModel {
 
   LauncherItems items_;
   Status status_;
-  ObserverList<LauncherModelObserver> observers_;
+  ObserverList<ShelfModelObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(LauncherModel);
 };
diff --git a/ash/launcher/launcher_model_observer.h b/ash/launcher/launcher_model_observer.h
deleted file mode 100644
index 16067c0..0000000
--- a/ash/launcher/launcher_model_observer.h
+++ /dev/null
@@ -1,41 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef ASH_LAUNCHER_LAUNCHER_MODEL_OBSERVER_H_
-#define ASH_LAUNCHER_LAUNCHER_MODEL_OBSERVER_H_
-
-#include "ash/ash_export.h"
-#include "ash/launcher/launcher_types.h"
-
-namespace ash {
-
-struct LauncherItem;
-
-class ASH_EXPORT LauncherModelObserver {
- public:
-  // Invoked after an item has been added to the model.
-  virtual void LauncherItemAdded(int index) = 0;
-
-  // Invoked after an item has been removed. |index| is the index the item was
-  // at.
-  virtual void LauncherItemRemoved(int index, LauncherID id) = 0;
-
-  // Invoked after an item has been moved. See LauncherModel::Move() for details
-  // of the arguments.
-  virtual void LauncherItemMoved(int start_index, int target_index) = 0;
-
-  // Invoked when the state of an item changes. |old_item| is the item
-  // before the change.
-  virtual void LauncherItemChanged(int index, const LauncherItem& old_item) = 0;
-
-  // Invoked when launcher status is changed.
-  virtual void LauncherStatusChanged() = 0;
-
- protected:
-  virtual ~LauncherModelObserver() {}
-};
-
-}  // namespace ash
-
-#endif  // ASH_LAUNCHER_LAUNCHER_MODEL_OBSERVER_H_
diff --git a/ash/launcher/launcher_model_unittest.cc b/ash/launcher/launcher_model_unittest.cc
index 8d90f52..b22dee9 100644
--- a/ash/launcher/launcher_model_unittest.cc
+++ b/ash/launcher/launcher_model_unittest.cc
@@ -8,7 +8,7 @@
 #include <string>
 
 #include "ash/ash_switches.h"
-#include "ash/launcher/launcher_model_observer.h"
+#include "ash/shelf/shelf_model_observer.h"
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -17,10 +17,10 @@ namespace ash {
 
 namespace {
 
-// LauncherModelObserver implementation that tracks what message are invoked.
-class TestLauncherModelObserver : public LauncherModelObserver {
+// ShelfModelObserver implementation that tracks what message are invoked.
+class TestShelfModelObserver : public ShelfModelObserver {
  public:
-  TestLauncherModelObserver()
+  TestShelfModelObserver()
       : added_count_(0),
         removed_count_(0),
         changed_count_(0),
@@ -39,21 +39,21 @@ class TestLauncherModelObserver : public LauncherModelObserver {
     return result;
   }
 
-  // LauncherModelObserver overrides:
-  virtual void LauncherItemAdded(int index) OVERRIDE {
+  // ShelfModelObserver overrides:
+  virtual void ShelfItemAdded(int index) OVERRIDE {
     added_count_++;
   }
-  virtual void LauncherItemRemoved(int index, LauncherID id) OVERRIDE {
+  virtual void ShelfItemRemoved(int index, LauncherID id) OVERRIDE {
     removed_count_++;
   }
-  virtual void LauncherItemChanged(int index,
-                                   const LauncherItem& old_item) OVERRIDE {
+  virtual void ShelfItemChanged(int index,
+                                const LauncherItem& old_item) OVERRIDE {
     changed_count_++;
   }
-  virtual void LauncherItemMoved(int start_index, int target_index) OVERRIDE {
+  virtual void ShelfItemMoved(int start_index, int target_index) OVERRIDE {
     moved_count_++;
   }
-  virtual void LauncherStatusChanged() OVERRIDE {
+  virtual void ShelfStatusChanged() OVERRIDE {
   }
 
  private:
@@ -70,7 +70,7 @@ class TestLauncherModelObserver : public LauncherModelObserver {
   int changed_count_;
   int moved_count_;
 
-  DISALLOW_COPY_AND_ASSIGN(TestLauncherModelObserver);
+  DISALLOW_COPY_AND_ASSIGN(TestShelfModelObserver);
 };
 
 }  // namespace
@@ -82,7 +82,7 @@ class LauncherModelTest : public testing::Test {
 
   virtual void SetUp() {
     model_.reset(new LauncherModel);
-    observer_.reset(new TestLauncherModelObserver);
+    observer_.reset(new TestShelfModelObserver);
     EXPECT_EQ(0, model_->item_count());
 
     LauncherItem item;
@@ -99,7 +99,7 @@ class LauncherModelTest : public testing::Test {
   }
 
   scoped_ptr<LauncherModel> model_;
-  scoped_ptr<TestLauncherModelObserver> observer_;
+  scoped_ptr<TestShelfModelObserver> observer_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(LauncherModelTest);
diff --git a/ash/shelf/shelf_model_observer.h b/ash/shelf/shelf_model_observer.h
new file mode 100644
index 0000000..46df44e
--- /dev/null
+++ b/ash/shelf/shelf_model_observer.h
@@ -0,0 +1,41 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_SHELF_SHELF_MODEL_OBSERVER_H_
+#define ASH_SHELF_SHELF_MODEL_OBSERVER_H_
+
+#include "ash/ash_export.h"
+#include "ash/launcher/launcher_types.h"
+
+namespace ash {
+
+struct LauncherItem;
+
+class ASH_EXPORT ShelfModelObserver {
+ public:
+  // Invoked after an item has been added to the model.
+  virtual void ShelfItemAdded(int index) = 0;
+
+  // Invoked after an item has been removed. |index| is the index the item was
+  // at.
+  virtual void ShelfItemRemoved(int index, LauncherID id) = 0;
+
+  // Invoked after an item has been moved. See LauncherModel::Move() for details
+  // of the arguments.
+  virtual void ShelfItemMoved(int start_index, int target_index) = 0;
+
+  // Invoked when the state of an item changes. |old_item| is the item
+  // before the change.
+  virtual void ShelfItemChanged(int index, const LauncherItem& old_item) = 0;
+
+  // Invoked when shelf status is changed.
+  virtual void ShelfStatusChanged() = 0;
+
+ protected:
+  virtual ~ShelfModelObserver() {}
+};
+
+}  // namespace ash
+
+#endif  // ASH_SHELF_SHELF_MODEL_OBSERVER_H_
diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc
index 56b8a60..811dd71 100644
--- a/ash/shelf/shelf_view.cc
+++ b/ash/shelf/shelf_view.cc
@@ -429,7 +429,7 @@ void ShelfView::Init() {
     view_model_->Add(child, static_cast<int>(i - items.begin()));
     AddChildView(child);
   }
-  LauncherStatusChanged();
+  ShelfStatusChanged();
   overflow_button_ = new OverflowButton(this);
   overflow_button_->set_context_menu_controller(this);
   ConfigureChildView(overflow_button_);
@@ -1416,7 +1416,7 @@ void ShelfView::OnGestureEvent(ui::GestureEvent* event) {
     event->StopPropagation();
 }
 
-void ShelfView::LauncherItemAdded(int model_index) {
+void ShelfView::ShelfItemAdded(int model_index) {
   {
     base::AutoReset<bool> cancelling_drag(
         &cancelling_drag_model_changed_, true);
@@ -1452,7 +1452,7 @@ void ShelfView::LauncherItemAdded(int model_index) {
   }
 }
 
-void ShelfView::LauncherItemRemoved(int model_index, LauncherID id) {
+void ShelfView::ShelfItemRemoved(int model_index, LauncherID id) {
   if (id == context_menu_id_)
     launcher_menu_runner_.reset();
   {
@@ -1492,8 +1492,8 @@ void ShelfView::LauncherItemRemoved(int model_index, LauncherID id) {
     tooltip_->Close();
 }
 
-void ShelfView::LauncherItemChanged(int model_index,
-                                    const ash::LauncherItem& old_item) {
+void ShelfView::ShelfItemChanged(int model_index,
+                                 const LauncherItem& old_item) {
   const LauncherItem& item(model_->items()[model_index]);
   if (old_item.type != item.type) {
     // Type changed, swap the views.
@@ -1537,7 +1537,7 @@ void ShelfView::LauncherItemChanged(int model_index,
   }
 }
 
-void ShelfView::LauncherItemMoved(int start_index, int target_index) {
+void ShelfView::ShelfItemMoved(int start_index, int target_index) {
   view_model_->Move(start_index, target_index);
   // When cancelling a drag due to a launcher item being added, the currently
   // dragged item is moved back to its initial position. AnimateToIdealBounds
@@ -1547,7 +1547,7 @@ void ShelfView::LauncherItemMoved(int start_index, int target_index) {
     AnimateToIdealBounds();
 }
 
-void ShelfView::LauncherStatusChanged() {
+void ShelfView::ShelfStatusChanged() {
   if (ash::switches::UseAlternateShelfLayout())
     return;
   AppListButton* app_list_button =
diff --git a/ash/shelf/shelf_view.h b/ash/shelf/shelf_view.h
index 9723809..250ba3b 100644
--- a/ash/shelf/shelf_view.h
+++ b/ash/shelf/shelf_view.h
@@ -8,8 +8,8 @@
 #include <utility>
 #include <vector>
 
-#include "ash/launcher/launcher_model_observer.h"
 #include "ash/shelf/shelf_button_host.h"
+#include "ash/shelf/shelf_model_observer.h"
 #include "ash/wm/gestures/shelf_gesture_handler.h"
 #include "base/observer_list.h"
 #include "ui/app_list/views/app_list_drag_and_drop_host.h"
@@ -48,7 +48,7 @@ class ShelfLayoutManager;
 class ShelfTooltipManager;
 
 class ASH_EXPORT ShelfView : public views::View,
-                             public LauncherModelObserver,
+                             public ShelfModelObserver,
                              public views::ButtonListener,
                              public ShelfButtonHost,
                              public views::ContextMenuController,
@@ -247,13 +247,13 @@ class ASH_EXPORT ShelfView : public views::View,
   // Overridden from ui::EventHandler:
   virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE;
 
-  // Overridden from LauncherModelObserver:
-  virtual void LauncherItemAdded(int model_index) OVERRIDE;
-  virtual void LauncherItemRemoved(int model_index, LauncherID id) OVERRIDE;
-  virtual void LauncherItemChanged(int model_index,
-                                   const ash::LauncherItem& old_item) OVERRIDE;
-  virtual void LauncherItemMoved(int start_index, int target_index) OVERRIDE;
-  virtual void LauncherStatusChanged() OVERRIDE;
+  // Overridden from ShelfModelObserver:
+  virtual void ShelfItemAdded(int model_index) OVERRIDE;
+  virtual void ShelfItemRemoved(int model_index, LauncherID id) OVERRIDE;
+  virtual void ShelfItemChanged(int model_index,
+                                const LauncherItem& old_item) OVERRIDE;
+  virtual void ShelfItemMoved(int start_index, int target_index) OVERRIDE;
+  virtual void ShelfStatusChanged() OVERRIDE;
 
   // Overridden from ShelfButtonHost:
   virtual void PointerPressedOnButton(views::View* view,