diff options
| author | pkotwicz <pkotwicz@chromium.org> | 2014-10-19 17:48:17 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-20 00:48:49 +0000 |
| commit | d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee (patch) | |
| tree | 8d3d3a6ce1081cf35cc4e25877653820dd6629b8 /athena/athena.gyp | |
| parent | 89b463ddd92b4c9abe7898506ccb4935cef75d1e (diff) | |
| download | chromium_src-d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee.zip chromium_src-d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee.tar.gz chromium_src-d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee.tar.bz2 | |
Revert of Support modal windows (patchset #4 id:80001 of https://codereview.chromium.org/662763002/)
Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)
Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression
Original issue's description:
> Support modal windows
>
> * New ContainerParams
> - default_parent to specify the default parent when no
> transient parent is specified.
> - modal_container_priority now controls the modal container
> used for a modal window created for the given container.
> - if not specified, it will fallback downwards to find one.
> - if window is specified as always_on_top, it will use top
> most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
> Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}
TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499
Review URL: https://codereview.chromium.org/665803003
Cr-Commit-Position: refs/heads/master@{#300226}
Diffstat (limited to 'athena/athena.gyp')
| -rw-r--r-- | athena/athena.gyp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/athena/athena.gyp b/athena/athena.gyp index ba463af..4084fb2 100644 --- a/athena/athena.gyp +++ b/athena/athena.gyp @@ -84,8 +84,6 @@ 'screen/screen_accelerator_handler.cc', 'screen/screen_accelerator_handler.h', 'screen/screen_manager_impl.cc', - 'screen/modal_window_controller.cc', - 'screen/modal_window_controller.h', 'system/background_controller.cc', 'system/background_controller.h', 'system/network_selector.cc', @@ -276,8 +274,6 @@ 'test/base/test_app_model_builder.cc', 'test/base/test_app_model_builder.h', 'test/base/test_resource_manager_delegate.cc', - 'test/base/test_windows.cc', - 'test/base/test_windows.h', 'wm/test/window_manager_impl_test_api.cc', 'wm/test/window_manager_impl_test_api.h', ], @@ -305,7 +301,6 @@ 'input/input_manager_unittest.cc', 'resource_manager/memory_pressure_notifier_unittest.cc', 'resource_manager/resource_manager_unittest.cc', - 'screen/modal_window_controller_unittest.cc', 'screen/screen_manager_unittest.cc', 'test/base/athena_unittests.cc', 'util/drag_handle_unittest.cc', |