diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-08 23:13:45 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-08 23:13:45 +0000 |
| commit | 4e9b3d53c28910dc0d9543a88cffbf0928a9b6dc (patch) | |
| tree | c33f09d319720494b015b3c867740bed9d510a19 /base/DEPS | |
| parent | 78be13f09f7bcf17126623926ca06eb823ff5378 (diff) | |
| download | chromium_src-4e9b3d53c28910dc0d9543a88cffbf0928a9b6dc.zip chromium_src-4e9b3d53c28910dc0d9543a88cffbf0928a9b6dc.tar.gz chromium_src-4e9b3d53c28910dc0d9543a88cffbf0928a9b6dc.tar.bz2 | |
Pass the shared memory handle in to StatsTable rather than consulting the GlobaDescriptors.
Remove the IPC dependency from base and updates the DEPS files to prevent this from happening again (ipc is in the root dir's deps file so is implicitly allowed here).
The Chrome unit tests did a bunch of work to delete the stats file when running under Posix. But this filename is never used on Posix, so I deleted this code. The unit tests now use an anonymous stats table which this code now supports.
The stats table unit test is disabled. It does not work on Posix systems at all because handle sharing is not set up. I put a Windows ifdef around this code (leaving it disabled) so I could use the Windows-style initializers, and verified that the test passes on Windows if I undisable it.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/224713017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262540 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/DEPS')
| -rw-r--r-- | base/DEPS | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -10,6 +10,9 @@ include_rules = [ "+third_party/modp_b64", "+third_party/tcmalloc", + # IPC is implicitly brought in from the root, and we don't want it. + "-ipc", + # ICU dependendencies must be separate from the rest of base. "-i18n", ] |