diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-12 20:31:59 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-12 20:31:59 +0000 |
| commit | 7dca611cc999457d6b704a8feced82af266cd82a (patch) | |
| tree | 9b1d514f72c59d952eafd14946152d5d5afbcd22 /base/allocator/allocator_shim.cc | |
| parent | 8ecbc2b0762c780c7ef1129256ce2bfb78df84aa (diff) | |
| download | chromium_src-7dca611cc999457d6b704a8feced82af266cd82a.zip chromium_src-7dca611cc999457d6b704a8feced82af266cd82a.tar.gz chromium_src-7dca611cc999457d6b704a8feced82af266cd82a.tar.bz2 | |
Add redundancy to detect double frees in TCMalloc
Added a single byte or word (tranparently) to all
allocations, and wrote a unique value into that
location after each allocation. When free() is
called, we validate the flag, and then mark
the block as not being allocated.
Any time a block fails to validate, we crash,
as this means the object either overran its
allocated region (or suffered memory corruption),
or else (more likely) a double free took place.
We have two distinct crash stacks for the
two distinct validation problems (corrupt vs
double free).
I did a first landing of this patch to test perf impact
and see what corruption it surfaced in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77941
It appears that Windows is not using TCMalloc on our bots.
TBR=mbelshe
Review URL: http://codereview.chromium.org/6683027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77948 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/allocator/allocator_shim.cc')
| -rw-r--r-- | base/allocator/allocator_shim.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/allocator/allocator_shim.cc b/base/allocator/allocator_shim.cc index f11164c..0bee3d3 100644 --- a/base/allocator/allocator_shim.cc +++ b/base/allocator/allocator_shim.cc @@ -41,7 +41,7 @@ typedef enum { // See SetupSubprocessAllocator() to specify a default secondary (subprocess) // allocator. // TODO(jar): Switch to using TCMALLOC for the renderer as well. -static Allocator allocator = WINHEAP; +static Allocator allocator = TCMALLOC; // The names of the environment variables that can optionally control the // selection of the allocator. The primary may be used to control overall |